[jbosstools-issues] [JBoss JIRA] (JBIDE-22263) Deploy Docker Wizard: Reset button on Deployment Configuration wizard page in Deploy Image could reset ALL env. vars

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198669#comment-13198669 ] 

Viacheslav Kabanovich edited comment on JBIDE-22263 at 4/28/16 5:45 PM:
------------------------------------------------------------------------

There is a couple of points that can be fixed and enhanced.
1. Added env var is not selected. Edited/reset env var looses selection.
2. User cannot see which env vars he added, and which values he edited. I suggest to render added/edited values in italic.
3. Implementing (2) will allow to enable buttons 'Reset' and 'Reset All' only when there is something they can change.
4. When 'Edit Environment Variable' is opened with uneditable Name field, it has cursor which unnecessary makes user to change focus to value. Value field in this case should be initially focused and value selected.

Screenshot EnvVarsEnhancement.png illustrates points (2) and (3):
- Line 'n141 yyyyy' is all in italic,  because I added this env var,
- Line 'n13 v13xxxxx' has italic value cell because it is edited,
- Button Reset is disabled because value in line 'n11 v11' is not edited,
- Button 'Reset All' is enabled because there is an edited value (in line 'n13 v13xxxxx')


was (Author: scabanovich):
There is a couple of points that can be fixed and enhanced.
1. Added env var is not selected. Edited/reset env var looses selection.
2. User cannot see which env vars he added, and which values he edited. I suggest to select to set background to added/edited values to a light grey color.
3. Implementing (2) will allow to enable buttons 'Reset' and 'Reset All' only when there is something they can change.
4. When 'Edit Environment Variable' is opened with uneditable Name field, it has cursor which unnecessary makes user to change focus to value. Value field in this case should be initially focused and value selected.

Screenshot EnvVarsEnhancement.png illustrates points (2) and (3):
- Line 'n141 yyyyy' is all grey,  because I added this env var,
- Line 'n13 v13xxxxx' has grey value cell because it is edited,
- Button Reset is disabled because value in line 'n11 v11' is not edited,
- Button 'Reset All' is enabled because there is an edited value (in line 'n13 v13xxxxx')

> Deploy Docker Wizard: Reset button on Deployment Configuration wizard page in Deploy Image could reset ALL env. vars
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-22263
>                 URL: https://issues.jboss.org/browse/JBIDE-22263
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.0.Alpha1
>            Reporter: Marián Labuda
>            Assignee: Viacheslav Kabanovich
>            Priority: Minor
>              Labels: deploy_docker_wizard, docker, openshift_v3
>             Fix For: 4.4.0.Alpha2
>
>         Attachments: EnvVarsEnhancement.png
>
>
> In Deploy Image to OpenShift wizard on the wizard page containing environment variables there is a Reset button. At the moment reset works only for one environment variable at the moment. It would be nice, if reset would set all environment variables (whole table) to default state. Currently the next wizard page containing ports mapping behave in desired way (reset set ports to default values), therefore it would be nice to have it consistent across wizard pages which are next to each other.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)