[jbosstools-issues] [JBoss JIRA] (JBIDE-22446) Release process should disallow inclusion of snapshots artifacts

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274746#comment-13274746 ] 

Nick Boldt commented on JBIDE-22446:
------------------------------------

Turns out the NPE was caused by my trying to do null.equals(). I've fixed that here: https://github.com/jbosstools/jbosstools-maven-plugins/commit/40a84804e004ec2441bd1a67cbf9cf2facb6e06f#diff-6eb689f9dcd629c3b522b8f1e6974eeeR109

And, I've enabled the enforcer check on all projects (instead of <pluginManagement> I put it into <plugins> in the parent pom):

https://github.com/jbosstools/jbosstools-build/commit/98f8bc98f8687237616eb41e40cfbdcc5326fba0#diff-04dc5d029560773ac79faaf3da0fbb22R439

So, openshift.client plugin build will now fail unless you disable/override this check, using this PR:

https://github.com/jbosstools/jbosstools-openshift/pull/1275/files?w=1

There are three ways to save the build from failing:

* include openshift-restclient-java.version in the <excludePattern>...</excludePattern> regex (permanent exception)
* <buildAliasSearch>Final|GA</buildAliasSearch> instead of <buildAliasSearch>AM3|Final|GA</buildAliasSearch> (but it'll fail again in the Final sprint)
* setting <fail>false</fail> (only a warning will be thrown in the build log)

> Release process should disallow inclusion of snapshots artifacts
> ----------------------------------------------------------------
>
>                 Key: JBIDE-22446
>                 URL: https://issues.jboss.org/browse/JBIDE-22446
>             Project: Tools (JBoss Tools)
>          Issue Type: Release
>          Components: build
>    Affects Versions: 4.4.0.Alpha2
>            Reporter: Jeff MAURY
>            Assignee: Nick Boldt
>             Fix For: 4.4.1.AM3
>
>
> 4.4.0.Alpha2 was generated with a SNAPSHOT dependency. This should be avoided in future releases even for Alpha ones
> Update: This issues is for adding some automated test/check to detect situation when our release includes a snapshot dependency.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)