[jbosstools-issues] [JBoss JIRA] (JBIDE-22968) if a build fails to publish, future builds may think there's nothing new and also not publish

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278655#comment-13278655 ] 

Andre Dietisheim edited comment on JBIDE-22968 at 8/16/16 11:29 AM:
--------------------------------------------------------------------

p2diff deep comparison is not a binary comparison of the IUs but a "deeper" comparison of their p2 metadata:
https://github.com/irbull/p2diff/blob/master/org.eclipse.equinox.p2.example.p2diff/src/org/eclipse/equinox/p2/example/p2diff/DeepIUCompare.java#L32
{code}
/**
 * Does a deep compare on two IUs.  A deep compare will return differences inside
 * two IUs (with the same ID), where the differences are more than just 'version' differences. 
 *
 * For example, assume we have two IUs A and B - Where A and B have the same ID but different versions
 * The DeepIUCompare will find the parts of these IUs that differ. However, if a part only differs by a version number,
 * that is, for example, if all the requirements are the same but the versions are different, this will not be reported.
 * 
 * This tool allows you to find elements that have been added or removed from an IU.  
 * 
{code}
I dont see any checks on IU hash or size, just deeper inspection of the p2 metadata (properties, requirements, etc.)


was (Author: adietish):
p2diff deep comparison is not a binary comparison of the IU binaries but a "deeper" comparison of their p2 metadata:
https://github.com/irbull/p2diff/blob/master/org.eclipse.equinox.p2.example.p2diff/src/org/eclipse/equinox/p2/example/p2diff/DeepIUCompare.java#L32
{code}
/**
 * Does a deep compare on two IUs.  A deep compare will return differences inside
 * two IUs (with the same ID), where the differences are more than just 'version' differences. 
 *
 * For example, assume we have two IUs A and B - Where A and B have the same ID but different versions
 * The DeepIUCompare will find the parts of these IUs that differ. However, if a part only differs by a version number,
 * that is, for example, if all the requirements are the same but the versions are different, this will not be reported.
 * 
 * This tool allows you to find elements that have been added or removed from an IU.  
 * 
{code}
I dont see any checks on IU hash or size, just deeper inspection of the p2 metadata (properties, requirements, etc.)

> if a build fails to publish, future builds may think there's nothing new and also not publish
> ---------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-22968
>                 URL: https://issues.jboss.org/browse/JBIDE-22968
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.4.1.AM3
>
>         Attachments: openshift-failed-future-builds-did-not-publish.png
>
>
> When publishing snapshots to download.jboss.org via Jenkins jobs, we need to add a check for "did the last build fail? if so, set skipRevisionCheckWhenPublishing = true"
> That way we don't get situations where the Openshift build fails (because failed enforcer check) and then the next 4-5 builds are NOT published (because as far as the current tests are concerned, the latest SHA in Jenkins == latest SHA in github... but NOT the latest SHA on download.jboss.org/.../snapshots/JOB_NAME/latest/.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)