[jbosstools-issues] [JBoss JIRA] (JBIDE-22446) Release process should disallow inclusion of snapshots artifacts

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280354#comment-13280354 ] 

Nick Boldt commented on JBIDE-22446:
------------------------------------

No, it shouldn't fail... because there is no SNAPSHOT dependency in openshift at the moment (it was replaced with RC1 [1]).

[1] https://github.com/jbosstools/jbosstools-openshift/commit/9213c7febc4afe37889eb300340ecb24e9a1e60c

If you re-insert a SNAPSHOT dep, then yes, it will fail:

{code:title=1. tweak parent pom to set new BUILD_ALIAS=Final and switch to non-SNAPSHOT target platform version}
cd ~/tru/jbosstools-build/parent/
cat pom.xml | grep AM3
sed -i -e "s#<BUILD_ALIAS>AM3</BUILD_ALIAS>#<BUILD_ALIAS>Final</BUILD_ALIAS>#" -e "s#4.60.1.AM3-SNAPSHOT#4.60.1.Final#g" pom.xml
mvn clean install
{code}

{code:title=2. use SNAPSHOT version of restclient jar in openshift.client, then rebuild using existing target platform 4.60.1.AM3-SNAPSHOT (because Final doesn't exist yet)}
cd ~/tru/jbosstools-openshift
git revert 9213c7febc4afe37889eb300340ecb24e9a1e60c
mvn clean verify -DskipTests  -Dtycho.baseline=disable -U -DTARGET_PLATFORM_VERSION=4.60.1.AM3-SNAPSHOT
{code}

{code:title=3. openshift.client plugin fails}
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (warn-no-snapshots-AM3) @ org.jboss.tools.openshift.client ---
Downloaded: https://repository.jboss.org/nexus/content/repositories/snapshots/org/jboss/tools/releng/enforcer-rules/0.25.1-SNAPSHOT/maven-metadata.xml (789 B at 2.0 KB/sec)
[ERROR] Found property openshift-restclient-java.version = 5.0.0-SNAPSHOT
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-no-snapshots-Final) @ org.jboss.tools.openshift.client ---
[ERROR] Found property openshift-restclient-java.version = 5.0.0-SNAPSHOT
[INFO] Found BUILD_ALIAS = Final (for buildAliasSearch = Final|GA)
[WARNING] Rule 0: org.jboss.tools.releng.NoSnapshotsAllowed failed with message:

When BUILD_ALIAS (Final) matches /Final|GA/, cannot include SNAPSHOT dependencies.

[INFO] BUILD FAILURE
{code}

So, this DOES work, but the enforcer plugin is NOT looking at commandline params. It's only looking at the values hardcoded in the parent pom. Not sure if this is a good thing or a bug. [~mickael_istria] [~mmalina] WDYT?

> Release process should disallow inclusion of snapshots artifacts
> ----------------------------------------------------------------
>
>                 Key: JBIDE-22446
>                 URL: https://issues.jboss.org/browse/JBIDE-22446
>             Project: Tools (JBoss Tools)
>          Issue Type: Release
>          Components: build
>    Affects Versions: 4.4.0.Alpha2
>            Reporter: Jeff MAURY
>            Assignee: Nick Boldt
>             Fix For: 4.4.1.AM3
>
>
> 4.4.0.Alpha2 was generated with a SNAPSHOT dependency. This should be avoided in future releases even for Alpha ones
> Update: This issues is for adding some automated test/check to detect situation when our release includes a snapshot dependency.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)