[jbosstools-issues] [JBoss JIRA] (JBIDE-23008) openshift.cdk.feature.source missing from JBT site; causes baseline check to fail

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281649#comment-13281649 ] 

Mickael Istria commented on JBIDE-23008:
----------------------------------------

This rule is the conclusion of all discussions about require vs includes. It's not wrtten on documentation, but you can see this as a conclusion of several bugzilla tickets and mailing-list discussions (for example on the platform-releng-dev mailing-list).

Includes allow the included feature to be considered as internal and makes it not required to list it in the update-site category.xml. They get included transitively at build-time, whereas if they're marked as required, we need to make sure those are listed directly.

Decoupling is a good practice if there is value. Otherwise it's just adding complexity.

Using only plugins rather that feature would be a good thing IMO. But there are many other and so much legacy with features that make them eternal now.

PS: sorry for editing your post, I was willing to answer and tried a copy-pasted that turned out in an edit...


> openshift.cdk.feature.source missing from JBT site; causes baseline check to fail
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-23008
>                 URL: https://issues.jboss.org/browse/JBIDE-23008
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build, openshift, updatesite
>    Affects Versions: 4.4.1.AM3
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.4.1.Final
>
>
> Since the weekend (after I published an AM3 build into /neon/staging/updates/):
> {code}
> [INFO] --- tycho-source-plugin:0.25.0:plugin-source (plugin-source) @ org.jboss.tools.openshift.cdk.server ---
> [INFO] Building jar: /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/target/org.jboss.tools.openshift.cdk.server-3.3.0-SNAPSHOT-sources.jar
> [INFO]
> [INFO] --- target-platform-configuration:0.25.0:target-platform (default-target-platform) @ org.jboss.tools.openshift.cdk.server ---
> [INFO]
> [INFO] --- tycho-packaging-plugin:0.25.0:package-plugin (default-package-plugin) @ org.jboss.tools.openshift.cdk.server ---
> [INFO] Building jar: /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/target/org.jboss.tools.openshift.cdk.server-3.3.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- tycho-p2-plugin:0.25.0:p2-metadata-default (default-p2-metadata-default) @ org.jboss.tools.openshift.cdk.server ---
> [WARNING] MavenProject: org.jboss.tools.openshift.plugins:org.jboss.tools.openshift.cdk.server:3.3.0-SNAPSHOT @ /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/pom.xml: baseline and build artifacts have same version but different contents
> [INFO] MavenProject: org.jboss.tools.openshift.plugins:org.jboss.tools.openshift.cdk.server:3.3.0-SNAPSHOT @ /Users/fbricon/Dev/projects/jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/pom.xml
>     The main artifact has been replaced with the baseline version.
>     The following attached artifacts are not present in the baseline and have been removed: [sources]{code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)