[jbosstools-issues] [JBoss JIRA] (JBIDE-23593) Integration tests global refactoring: org.jboss.tools.ui.bot.ext.test

[Martin Malina (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13332081#comment-13332081 ] 

Martin Malina edited comment on JBIDE-23593 at 12/1/16 5:59 AM:
----------------------------------------------------------------

Actually, I was incorrect. org.jboss.tools.ui.bot.ext.test really were some tests of org.jboss.tools.ui.bot.ext which is in plugins/.
I thought we could just remove both of them. The build still worked, but then I found out that some tests still use bot.ext:
{code}
$ find . -iname 'manifest.mf' -path '*/META-INF/*'|xargs grep 'ui\.bot\.ext'|sed 's/:.*//'./plugins/org.jboss.tools.jst.ui.bot/META-INF/MANIFEST.MF
./plugins/org.jboss.tools.perf.test.core/META-INF/MANIFEST.MF
./tests/org.jboss.tools.jsf.ui.bot.test/META-INF/MANIFEST.MF
./tests/org.jboss.tools.portlet.ui.bot.test/META-INF/MANIFEST.MF
./tests/org.jboss.tools.runtime.as.ui.bot.test/META-INF/MANIFEST.MF
./tests/org.jboss.tools.seam.ui.bot.test/META-INF/MANIFEST.MF
./tests/org.jboss.tools.ws.ui.bot.test/META-INF/MANIFEST.MF
{code}

So it's gonna take a bit longer before we're able to get rid of bot.ext. As for bot.ext.test, we discussed it and [~rawagner] had a good point:
{quote}
Nobody's gonna fix bot.ext (it's deprecated) even if bot.ext.test was to find a problem in it.
{quote}

So it's not worth bothering with it and it can be removed right now.


was (Author: mmalina):
Actually, I was incorrect. org.jboss.tools.ui.bot.ext.test really were some tests of org.jboss.tools.ui.bot.ext which is in plugins/. But anyway, let's remove both. PR will follow shortly.

> Integration tests global refactoring: org.jboss.tools.ui.bot.ext.test
> ---------------------------------------------------------------------
>
>                 Key: JBIDE-23593
>                 URL: https://issues.jboss.org/browse/JBIDE-23593
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: integration-tests
>    Affects Versions: 4.4.2.Final
>            Reporter: Jeff MAURY
>              Labels: integration, integration_tests
>             Fix For: 4.4.3.AM1
>
>
> Maven command:
> {code}
> mvn clean verify -Dtest.module=org.jboss.tools.ui.bot.ext.test -DskipTests=false
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)