[jbosstools-issues] [JBoss JIRA] (JBIDE-23648) integration tests: ImageTagTest tries to assert that uppercase tags cannot be added to docker images, but it fails to

[Andre Dietisheim (JIRA)]

Andre Dietisheim created JBIDE-23648:
----------------------------------------

             Summary: integration tests: ImageTagTest tries to assert that uppercase tags cannot be added to docker images, but it fails to
                 Key: JBIDE-23648
                 URL: https://issues.jboss.org/browse/JBIDE-23648
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: docker, integration-tests
    Affects Versions: 4.4.2.Final
            Reporter: Andre Dietisheim


ImageTagTest tries to assert that uppercase tags cannot be added to docker images. But it has 2 flaws:
* it tries to assert the existence of an error dialog (when providing an uppercase tag) via 		
  {code}new ShellWithTextIsAvailable("Error tagging image to <" + imageTagUppercase + ">"){code}
  but ShellWithTextIsAvailable is an AbstractWaitCondition. So it has no effect at all
* the docker tooling wont prevent you from providing an uppercase tag. It will actually accept it, send it to the daemon and then display it. No error occurrs. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=509223

The assertion itself is absolutely correct. The cmd line wont accept uppercase letters in a tag.




--
This message was sent by Atlassian JIRA
(v7.2.3#72005)