[jbosstools-issues] [JBoss JIRA] (JBIDE-21615) Cannot save changes for launch configuration in CDK Adapter Configuration Editor

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157130#comment-13157130 ] 

Rob Stryker commented on JBIDE-21615:
-------------------------------------

As in all (most?) server adapters, we override parts of the launch configuration with information from the server editor.  This is not the approved mechanism of changing the username or the password. Those must be done in the server editor itself and the credential framework. 

However, other changes to the launch configuration, such as changes to the 'main' tab, arguments, vagrant command location, etc, should be persisted, and adding new environment variables should also be persisted properly. However removing or changing critical variables (such as those set in server editor) will be overridden by the values in the server editor. 

I'm inclined to reject this JIRA, since other changes to the launch config are persisted as expected and I consider this to be functioning normally. 

> Cannot save changes for launch configuration in CDK Adapter Configuration Editor
> --------------------------------------------------------------------------------
>
>                 Key: JBIDE-21615
>                 URL: https://issues.jboss.org/browse/JBIDE-21615
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, server
>    Affects Versions: 4.4.0.Alpha1
>         Environment: Windows 10
>            Reporter: Denis Golovin
>         Attachments: CDK launch config changes are not saved.mp4
>
>
> Launch configuration changes discarded in CDK Server Configuration Editor see attached video 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)