[jbosstools-issues] [JBoss JIRA] (JBIDE-21302) Removing user from credentials framework while not authenticated to secure storage should not work

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163604#comment-13163604 ] 

Rob Stryker commented on JBIDE-21302:
-------------------------------------

[~scabanovich] I like the solution, but unfortunately it breaks API compatibility.  See https://wiki.eclipse.org/Evolving_Java-based_APIs_2

Changing the return type of a method, especially an interface method with consumers, will break API compatibility, even when the existing return type was void. 

In order to avoid this, we'd need to know that every consumer *using* the API will be rebuilt. As of right now, known consumers are download runtimes, and CDK.  If we can guarantee that users who somehow get a new foundation will also get a new CDK and a new download runtimes, then the patch *could* be accepted for maintenance.  Otherwise, it will have to be master only. 

> Removing user from credentials framework while not authenticated to secure storage should not work
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21302
>                 URL: https://issues.jboss.org/browse/JBIDE-21302
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common/jst/core
>    Affects Versions: 4.3.1.Beta1
>         Environment: JBDS 9.0.0.Beta1-v20151210-1836-B183
>            Reporter: Radim Hopp
>            Assignee: Rob Stryker
>             Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> Removing credentials (which are stored in secure storage) using 
> CredentialPreferencePage without being authenticated to secure storage (see steps to reproduce on how to do that) seems to delete the credentials, but after eclipse restart, the credentials are still there. I would prefer message saying something like "Unable to delete credentials stored in secure storage without atuhenticating to secure storage".



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)