[jbosstools-issues] [JBoss JIRA] (JBIDE-21302) Removing user from credentials framework while not authenticated to secure storage should not work

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163661#comment-13163661 ] 

Viacheslav Kabanovich commented on JBIDE-21302:
-----------------------------------------------

We can add new method - boolean save() - and mark the old one - void saveModel() - as deprecated. That will not break compatibility.
Implementation of old saveModel() will just call save() without using its return. All clients you mention will continue using this old method. Removing user will use new method.
Since interface name ICredentialsModel has 'Model' in it, I think it may be ok to have method save() without 'Model' - and Javadoc may explain exactly what it saves. [~rob.stryker], may I do that change to the pull request?

> Removing user from credentials framework while not authenticated to secure storage should not work
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21302
>                 URL: https://issues.jboss.org/browse/JBIDE-21302
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common/jst/core
>    Affects Versions: 4.3.1.Beta1
>         Environment: JBDS 9.0.0.Beta1-v20151210-1836-B183
>            Reporter: Radim Hopp
>            Assignee: Rob Stryker
>             Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> Removing credentials (which are stored in secure storage) using 
> CredentialPreferencePage without being authenticated to secure storage (see steps to reproduce on how to do that) seems to delete the credentials, but after eclipse restart, the credentials are still there. I would prefer message saying something like "Unable to delete credentials stored in secure storage without atuhenticating to secure storage".



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)