[jbosstools-issues] [JBoss JIRA] (JBIDE-21356) Make OpenShift 3 resource edition more robust

[Fred Bricon (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-21356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Bricon resolved JBIDE-21356.
---------------------------------
      Assignee: Fred Bricon
    Resolution: Done


Made sure to fall back on wst's JSON editor (or the default editor, if the former is unavailable), in case opening the current editor fails.
Had to append the resource name with .json in order to get colored syntax in the JSON editor

> Make OpenShift 3 resource edition more robust
> ---------------------------------------------
>
>                 Key: JBIDE-21356
>                 URL: https://issues.jboss.org/browse/JBIDE-21356
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Fred Bricon
>            Assignee: Fred Bricon
>             Fix For: 4.3.1.CR1
>
>
> Following [~scabanovich]'s comment in JBIDE-20761:
> {quote}
> My concern is that the default editor is called if it is set for .json without a fallback for a case of failure of that unknown editor. We cannot be sure what editor a user may have set to be default for .json. That editor may be expecting some specific instance of editor input object and fail on what is provided. As it is, then json will not be opened at all, neither fancy nor plain text. However, if it is just temporal, till the expected contribution to jsdt, and that editor is going to be hardcoded to be opened, then no problem.
> {quote}
> Until we can rely on Eclipse's upcoming JSON editor (in Neon), we should try to harden editor detection/opening



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)