[jbosstools-issues] [JBoss JIRA] (ERT-76) Sync of IJSONModel with editor should be improved/fixed [EBZ#486860]

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/ERT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167770#comment-13167770 ] 

Victor Rubezhny commented on ERT-76:
------------------------------------

I've pushed the workaround for the issue, so now we have no blocking issues with model synchronization while editing JSON documents.

Since the issue is not completely solved and we still need to improve the reconciling for JSON Editor - we're keeping the related bugzilla opened and assigned to IBM'ers and keeping this issue open for track purposes.

> Sync of IJSONModel with editor should be improved/fixed [EBZ#486860]
> --------------------------------------------------------------------
>
>                 Key: ERT-76
>                 URL: https://issues.jboss.org/browse/ERT-76
>             Project: Eclipse Release Train
>          Issue Type: Task
>          Components: WTP Source Editing
>            Reporter: Nick Boldt
>            Assignee: Victor Rubezhny
>              Labels: bzira, wst.json
>             Fix For: Neon (4.6) M6
>
>
> IMHO the sync of IJSONModel with editor is the most important and should be done/fixed before fixing, improving other features. But it is the most hard too.
> At first, we should validate the IJSONModel API
> The big problem with JSON Editor is that the IJSONModel, IJSONPair, IJSONDocument, etc. There are a lot of copy/paste from XML/CSS plugins so this model and the implementation should be really fixed/improved.
> For instance completion works when editor is opened, but it is broken after some changes of the text editor. It is because IJSONModel is not very well sync.
> The most bugs that I see like:
>  * https://bugs.eclipse.org/bugs/show_bug.cgi?id=486606
>  * https://bugs.eclipse.org/bugs/show_bug.cgi?id=485694
>  * https://bugs.eclipse.org/bugs/show_bug.cgi?id=486849
>  * https://bugs.eclipse.org/bugs/show_bug.cgi?id=486524
> are linked to this sync problem.
> So tests https://github.com/angelozerr/eclipse-wtp-json/blob/master/core/org.eclipse.wst.json.core.tests/src/org/eclipse/wst/json/core/document/JSONObjectDocumentChangesTest.java must be completed when sync of model is improved.
> I will try to create a patch for adding tests https://bugs.eclipse.org/bugs/show_bug.cgi?id=486238 
> It's a very hard task, so good luck to do that.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)