[jbosstools-issues] [JBoss JIRA] (JBIDE-21763) Environment variables validation in deploy docker image wizard is not correct/consistent

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168504#comment-13168504 ] 

Viacheslav Kabanovich commented on JBIDE-21763:
-----------------------------------------------

'Value' input is not validated because its content depends on the variable name.
So, in the error message we have only to replace 'value' with 'name' (or 'name value', but it would look redundant, and still may be confusing because of 'value' input on the same page). 

Concerning validation of 'value', this reference https://developers.openshift.com/en/managing-environment-variables.html describes rules for values of some variables. Can we implement them as a feature? Could it be also of use to add to 'name' input content assist that would suggest these variable names? [~jcantrill], [~fbricon], what do you think?

> Environment variables validation in deploy docker image wizard is not correct/consistent
> ----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21763
>                 URL: https://issues.jboss.org/browse/JBIDE-21763
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.CR1
>            Reporter: Marián Labuda
>            Assignee: Viacheslav Kabanovich
>              Labels: docker, openshift_v3
>         Attachments: env_var_validation.png, invalid_env_var_value.png
>
>
> On 2nd page of Deploy Docker Image wizard is page containing environment variable. Dialog to create a new environment variable has a validation message but it is not correct, or at least validation message content does not fit reality. See following screenshots:
> First one is when entered invalid environment variable name. Notice message contains info about invalid value, not name, although it is name what is not valid.
> !env_var_validation.png!
> Second screeshoot displays so-called invalid value (regarding to validation message in first screenshot), but there is no validation error.
> !invalid_env_var_value.png!



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)