[jbosstools-issues] [JBoss JIRA] (JBIDE-21742) Secure storage of OpenShift 3 token does not work

[Marián Labuda (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168854#comment-13168854 ] 

Marián Labuda edited comment on JBIDE-21742 at 2/26/16 6:25 AM:
----------------------------------------------------------------

It is working. But still there is an error in error log with following stack. Is this desired? Should not we hide this message, because we are handling it with that warning dialog and this is not something unexpected? Otherwise it is verified on lates nightly JBT build with OpenShift tooling build B197.
{code}
org.jboss.tools.openshift.internal.common.core.security.SecureStoreException: Could not store value token: XXX
	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:104)
	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.put(SecureStore.java:57)
	at org.jboss.tools.openshift.core.connection.Connection.saveOrClear(Connection.java:191)
	at org.jboss.tools.openshift.core.connection.Connection.save(Connection.java:162)
	at org.jboss.tools.openshift.core.connection.Connection.connect(Connection.java:216)
	at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizardPageModel.connect(ConnectionWizardPageModel.java:355)
	at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizardPage$ConnectJob.doRun(ConnectionWizardPage.java:476)
	at org.jboss.tools.openshift.internal.common.core.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Caused by: org.eclipse.equinox.security.storage.StorageException: No password provided.
	at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getModulePassword(SecurePreferencesRoot.java:304)
	at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getPassword(SecurePreferencesRoot.java:224)
	at org.eclipse.equinox.internal.security.storage.SecurePreferences.put(SecurePreferences.java:224)
	at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.put(SecurePreferencesWrapper.java:110)
	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:102)
	... 8 more

{code}


was (Author: mlabuda):
It is working. But still there is an error in error log with following stack. Is this desired? Should not we hide this message, because we are handling it with that warning dialog and this is not something unexpected?
{code}
org.jboss.tools.openshift.internal.common.core.security.SecureStoreException: Could not store value token: XXX
	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:104)
	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.put(SecureStore.java:57)
	at org.jboss.tools.openshift.core.connection.Connection.saveOrClear(Connection.java:191)
	at org.jboss.tools.openshift.core.connection.Connection.save(Connection.java:162)
	at org.jboss.tools.openshift.core.connection.Connection.connect(Connection.java:216)
	at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizardPageModel.connect(ConnectionWizardPageModel.java:355)
	at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizardPage$ConnectJob.doRun(ConnectionWizardPage.java:476)
	at org.jboss.tools.openshift.internal.common.core.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Caused by: org.eclipse.equinox.security.storage.StorageException: No password provided.
	at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getModulePassword(SecurePreferencesRoot.java:304)
	at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getPassword(SecurePreferencesRoot.java:224)
	at org.eclipse.equinox.internal.security.storage.SecurePreferences.put(SecurePreferences.java:224)
	at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.put(SecurePreferencesWrapper.java:110)
	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:102)
	... 8 more

{code}

> Secure storage of OpenShift 3 token does not work
> -------------------------------------------------
>
>                 Key: JBIDE-21742
>                 URL: https://issues.jboss.org/browse/JBIDE-21742
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.CR1
>            Reporter: Marián Labuda
>            Assignee: Viacheslav Kabanovich
>              Labels: connection, openshift_v3, security_domain
>             Fix For: 4.3.1.CR1
>
>         Attachments: SecureStorageAccessFailure.png
>
>
> When I have already user secure storage in another session (password is set) and I fill in valid token and check checkbox to store token in secure storage, confirmation dialog of secure storage is shown upon hitting Finish button. Upon filling invalid secure storage password for first time, dialog is invoked again to enter password. After second filling of invalid password for secure storage, it looks like it passed - no other prompt nor error dialog (just in error log see stack trace) and even in Connection dialog (opened via Edit context menu item on the connection) is checkbox for secure storage checked, what is wrong, because it is not stored (checked secure storage preference page and its content and also after restart of eclipse it was not stored).
> {code}
> org.jboss.tools.openshift.internal.common.core.security.SecureStoreException: Could not store value token: iQKo-5jRkMeaegCi3mljsFsAXhNaogmzwaKeaQNUAxc
> 	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:104)
> 	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.put(SecureStore.java:57)
> 	at org.jboss.tools.openshift.core.connection.Connection.saveOrClear(Connection.java:187)
> 	at org.jboss.tools.openshift.core.connection.Connection.save(Connection.java:159)
> 	at org.jboss.tools.openshift.core.connection.Connection.connect(Connection.java:207)
> 	at org.jboss.tools.openshift.core.connection.Connection.retryList(Connection.java:424)
> 	at org.jboss.tools.openshift.core.connection.Connection.getResources(Connection.java:368)
> 	at org.jboss.tools.openshift.core.connection.Connection.getResources(Connection.java:355)
> 	at org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectCache.getProjectsFor(OpenShiftProjectCache.java:60)
> 	at org.jboss.tools.openshift.internal.ui.explorer.OpenShiftExplorerContentProvider.getChildrenFor(OpenShiftExplorerContentProvider.java:95)
> 	at org.jboss.tools.openshift.internal.common.ui.explorer.BaseExplorerContentProvider$1.run(BaseExplorerContentProvider.java:167)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> Caused by: org.eclipse.equinox.security.storage.StorageException: No password provided.
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getModulePassword(SecurePreferencesRoot.java:304)
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getPassword(SecurePreferencesRoot.java:224)
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferences.put(SecurePreferences.java:224)
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.put(SecurePreferencesWrapper.java:110)
> 	at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:102)
> 	... 11 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)