[jbosstools-issues] [JBoss JIRA] (JBIDE-20603) context menu of openshift is not using global commands like delete or properties

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144729#comment-13144729 ] 

Viacheslav Kabanovich edited comment on JBIDE-20603 at 1/4/16 3:14 PM:
-----------------------------------------------------------------------

Actually, it is ok that there are custom delete commands for handling specific objects. We just have to hook them to global action handler for 'Delete', 'Properties' etc. To do this, we have to add to extension 
{code}
<navigatorContent contentProvider="org.jboss.tools.openshift.internal.ui.explorer.OpenShiftExplorerContentProvider"> 
{code}
part <actionProvider> with implementation extending CommonActionProvider, and override method fillActionBars(IActionBars) in order to register custom actions for global handlers
{code}
IActionBars.setGlobalActionHandler(String actionId, IAction handler);
{code}


was (Author: scabanovich):
Actually, it is ok that there are custom delete commands for handling specific objects. We just have to hook them to global action handler for 'Delete', 'Properties' etc. To do this, we have to add to extension 
{code>
<navigatorContent contentProvider="org.jboss.tools.openshift.internal.ui.explorer.OpenShiftExplorerContentProvider"> 
{code}
part <actionProvider> with implementation extending CommonActionProvider, and override method fillActionBars(IActionBars) in order to register custom actions for global handlers
{code}
IActionBars.setGlobalActionHandler(String actionId, IAction handler);
{code}

> context menu of openshift is not using global commands like delete or properties
> --------------------------------------------------------------------------------
>
>                 Key: JBIDE-20603
>                 URL: https://issues.jboss.org/browse/JBIDE-20603
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Priority: Critical
>             Fix For: 4.3.1.Beta2
>
>
> Delete Project, resource etc. should use the normal Delete command. It seems we've created custom commands and UI for it instead of just using the default Delete command as used in other context menus.
> Similar we dont seem to use standard Properties
> see https://wiki.eclipse.org/Menu_Contributions/Problems_View_Example on how to use org.eclipse.ui.edit.delete etc.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)