[jbosstools-issues] [JBoss JIRA] (JBIDE-21399) Editor should be shown as dirty if saving of modified resource failed

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145231#comment-13145231 ] 

Viacheslav Kabanovich edited comment on JBIDE-21399 at 1/5/16 7:37 PM:
-----------------------------------------------------------------------

Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix will not work.
Anyway, trying to fix the issue with setting info.fCanBeSaved and firing state changed event seems the best approach.


was (Author: scabanovich):
Editor is saved in a separate job that can be executed while shown in modal dialog or in background depending on preference RUN_IN_BACKGROUND. The fix should be tested in both modes. Unfortunately, I cannot find this preference in Preferences dialog. OpenShiftResourceDocumentProvider.SaveOperation sets info.fCanBeSaved=false when doSaveDocument() returns, it can happen before or after job is completed. If in some use case SaveOperation is the last one to touch info.fCanBeSaved, the fix willnot work.

> Editor should be shown as dirty if saving of modified resource failed
> ---------------------------------------------------------------------
>
>                 Key: JBIDE-21399
>                 URL: https://issues.jboss.org/browse/JBIDE-21399
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.0.Final
>            Reporter: Marián Labuda
>            Assignee: Fred Bricon
>             Fix For: 4.3.1.Beta2
>
>
> After editing resource to inappropriate state and save it, there is an error that update of a resource failed but content of text editor is saved and its state does not reflect current state of resource on OS 3 server. If update of a resource was not successful, opened text editor with the given resource json should be still shown as dirty.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)