[jbosstools-issues] [JBoss JIRA] (JBIDE-21421) New Server adapter using same build config and server is ignored

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148402#comment-13148402 ] 

Viacheslav Kabanovich commented on JBIDE-21421:
-----------------------------------------------

In ServerSettingsViewModel.updateServer(IServerWorkingCopy), server name is computed by OpenShiftServerUtils.getServerName(), and then working copy is updated. We may check if the name is used by an existing server and find new name by adding suffix (n). Method updateServer(IServerWorkingCopy) is not called by OpenShiftServerEditorModel, only by wizard. That will implement suggestion (b). Imho, suggestion (a) is not good, because wizard named 'New Server' should not be used to edit an existing object. [~adietish], do you think my suggestion may be ok?

> New Server adapter using same build config and server is ignored
> ----------------------------------------------------------------
>
>                 Key: JBIDE-21421
>                 URL: https://issues.jboss.org/browse/JBIDE-21421
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta2
>            Reporter: Marián Labuda
>            Priority: Critical
>              Labels: openshift_v3, server_adapter
>
> When I have a OS3 server adapter in Server view and I open wizard to create a new server adapter from context menu of a servers view, the newly created server adapter is ignored if same build config name and server is used. E.g. I have a server api.engint.openshift.com and eap-app build config (related to the service that server adapter is supposed to be bind to). First time I create a new server adapter for this application, it is shown in servers view, but if I choose to create another server adapter for same build config and server, details filled in this newly opened server adapter wizard are ignored and new adapter is not created. 
> I would expect one of following:
> a) An existing server adapter will be updated according to the latest details filled in server adapter wizard
> b) There would be created another server adapter for the same service (and build config) and server but with altered name. This is possible solution because a server adapter name in wizard is already altered but it is never used anywhere.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)