[jbosstools-issues] [JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149655#comment-13149655 ] 

Viacheslav Kabanovich commented on JBIDE-21460:
-----------------------------------------------

Possible solutions:
1. Just prevent NPE and return null in getWelcomePageUrl(). 
    Disadvantage - action will do nothing silently.
2. Together with (1), implement hasWelcomePage() as getWelcomePageUrl() != null, catch exception and return false if one caught. 
    Advantage - Menu item in context menu will be disabled. 
    Disadvantages - The cause remains unknown. It make take a long time to open context menu.
3. While computing welcome page, find the cause of failure (e.g., 'not connected', 'error while retrieving resources', etc.), show message dialog with the problem.
[~adietish], what do you recommend?

> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-21460
>                 URL: https://issues.jboss.org/browse/JBIDE-21460
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Viacheslav Kabanovich
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> Failure: NPE while executing getWelcomePageUrl().



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)