[jbosstools-issues] [JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150099#comment-13150099 ] 

Viacheslav Kabanovich commented on JBIDE-21460:
-----------------------------------------------

[~adietish], yes the message is better to be shown. Now the exception is caught by Eclipse and shown in standard "Problem occured". If it is an OpenShiftException, it may be ok. We have only to prevent NPE and show it in a nicer way, also taking into account that after cancelling 'sign in' the failure is quite expected.

> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-21460
>                 URL: https://issues.jboss.org/browse/JBIDE-21460
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Viacheslav Kabanovich
>             Fix For: 4.3.1.CR1
>
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> 6. 'Sign In' dialog appears, select cancel. 
> (Note: First time when I got it, dialog did not appear, later I could not repeat steps that would skip the dialog.)
> 7. Failure: NPE while executing getWelcomePageUrl().



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)