[jbosstools-issues] [JBoss JIRA] (JBIDE-21460) NPE at Show In Web Browser for OpenShift server if connection is not connected

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153862#comment-13153862 ] 

Viacheslav Kabanovich edited comment on JBIDE-21460 at 1/27/16 1:22 AM:
------------------------------------------------------------------------

When a NPE was prevented, we know what happens and may just inform user of a problem without stack trace. If some non-trivial error happens inside OpenShift, we better let it be logged, what Job manager does when it catches an exception. 
[~adietish], please take a look at the refactored pull request. Original OpenShiftException is passed into GetApplicationException as the cause, and then our message dialog is shown instead of 'Problem Occured', and the original OpenShiftException is logged.


was (Author: scabanovich):
When a NPE was prevented, we know what happens and may just inform user of a problem without stack trace. If some non-trivial error happens inside OpenShift, we better let it be logged, what Job manager does when it catches an exception. 
[~adietish], should we wrap OpenShiftException into GetApplicationException and then show our message dialog instead of 'Problem Occured', and do the logging?

> NPE at Show In Web Browser for OpenShift server if connection is not connected
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-21460
>                 URL: https://issues.jboss.org/browse/JBIDE-21460
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Viacheslav Kabanovich
>             Fix For: 4.3.1.CR1
>
>         Attachments: not-authorized-error.png
>
>
> 1. Create an OpenShift connection, do not choose save password/token.
> 2. Create an OpenShift server for the connection.
> 3. Close Eclipse with Server view active
> 4. Restart Eclipse, select Server view.
> 5. In context menu of the server, select Show In Web Browser.
> 6. 'Sign In' dialog appears, select cancel. 
> (Note: First time when I got it, dialog did not appear, later I could not repeat steps that would skip the dialog.)
> 7. Failure: NPE while executing getWelcomePageUrl().



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)