[jbosstools-issues] [JBoss JIRA] (JBIDE-22694) Environment Var Wizard: Improve deletion of environment variables

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263910#comment-13263910 ] 

Viacheslav Kabanovich edited comment on JBIDE-22694 at 7/11/16 2:51 PM:
------------------------------------------------------------------------

The table shows changes that user is going to submit. They are reversible. When user changes an entry, he can push 'Reset' and the old value is restored. When user pushes 'Delete' he still does not delete the entry permanently, it is only marked to be deleted when OK is finally pressed. So, if the 'deleted' item is hidden from the table, how it can be reset? Then, if user pushed 'Delete' by mistake, he will have only to close/reopen the dialog to prevent the unwanted change. But actually, it is worse - if the deleted item is not shown in the table, user may not notice that he pushed 'Delete' by mistake. So, consistency in the case when user is given  the option to revert changes before he submits them is to be able to show all differences as it is done now. An alternative is to submit directly each change to server with no 'Reset' option, and 'Close' button instead of 'OK'+'Cancel' - that is irreversible management.
Compare it to GIT showing difference between stored state and local changed state. 


was (Author: scabanovich):
The table shows changes that user is going to submit. They are reversible. When user changes an entry, he can push 'Reset' and the old value is restored. When user pushes 'Delete' he still does not delete the entry permanently, it is only marked to be deleted when OK is finally pressed. So, if the 'deleted' item is hidden from the table, how it can be reset? Then, if user pushed 'Delete' by mistake, he will have only to close/reopen the dialog to prevent the unwanted change. But actually, it is worse - if the deleted item is not shown in the table, user may not notice that he pushed 'Delete' by mistake. So, consistency in the case when user is given  the option to revert changes before he submits them is to be able to show all differences as it is done now. An alternative is to submit directly each change to server with no 'Reset' option.
Compare it to GIT showing difference between stored state and local changed state. 

> Environment Var Wizard: Improve deletion of environment variables
> -----------------------------------------------------------------
>
>                 Key: JBIDE-22694
>                 URL: https://issues.jboss.org/browse/JBIDE-22694
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.1.AM1
>            Reporter: Marián Labuda
>              Labels: env_var_wizard, openshift_v3
>
> Deletion of environment variable does not match user expectation. If I delete an environment variable which has been added in earlier opened and closed Env. Var wizard, this variable has prefix [deleted]. I don't think this is good practice, we should be consistent across all wizards and dialog, so once user select an env var in table and push Delete button, value should be removed from the table. No labelling should be done here, the table should reflect real current state of environment variable (what it is gonna look like once I hit Finish button).



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)