[jbosstools-issues] [JBoss JIRA] (JBIDE-22695) Environment Variables of application deployment should have different workflow

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263935#comment-13263935 ] 

Viacheslav Kabanovich commented on JBIDE-22695:
-----------------------------------------------

'Manage Environment Variables' dialog just edits one part of a selected resource. If a dialog modifying a resource results in creating a new copy of the resource with readjusting the project to it, it will look as a bad implementation of the version control system. Resetting to original state may seem good for a project that has a short story of changes. If it had a lot of modifications, then some intermediate state may be more preferred than the original. Does Openshift keeps the history of changes for each resource? If it does, we might have a feature button 'Restore from History' to show versions and their differences from the current state. I would leave button 'Reset All' to do what it does now - handle diffs of current input from the last saved state. If Openshift does not keep the history, any hard-wired solution will have its limitations.
 

> Environment Variables of application deployment should have different workflow
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-22695
>                 URL: https://issues.jboss.org/browse/JBIDE-22695
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.1.AM1
>            Reporter: Marián Labuda
>            Priority: Critical
>              Labels: openshift_v3
>
> Reset All button in Environment Var wizard dialog should get application to default state. At the moment it reset environment variables in the table just to the values at the point of opening the wizard. If I would delete some environment variables and confirm changes, but I would find out I broke something and I would like to rollback it to original state, I would try to reset it with Reset All button. But it won't work for me. This is causing the more serious issue:
> Because we edit same deployment configuration and start deployments from it and in the same time we set number of replicas in other deployment configs to zero. So we don't have the original deployment config and thus we cannot rollback easily (well there is a way but nasty one - edit replication controller, copy and paste environment variables to the deployment config, save it and deploy latest).
> There are 2 options:
> a) Create a new deployment configuration for a new (modified) set of environment variables and create a new replication controller (deployment) from this deployment configuration. There is one con - it can lead to many deployment configurations and replication controllers (for each deployment configuration there would be one replication controller).
> b) Just edit current replication controller (deployment) of an application or create a new one from an existing but with modified env. vars and with correct amount of replicas and set replicas in the previous to 0. And then let respin pods with correct setup. One of those approaches (create/edit RC) would be, I think, more satisfying.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)