[jbosstools-issues] [JBoss JIRA] (JBIDE-22673) Need better duplicate IU detection when validating target platforms

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269493#comment-13269493 ] 

Nick Boldt edited comment on JBIDE-22673 at 7/22/16 4:26 PM:
-------------------------------------------------------------

PRs to move to 0.26.0-SNAPSHOT in maven-plugins, parent pom, target-platforms and discovery (to be applied in next sprint!):

https://github.com/jbosstools/jbosstools-maven-plugins/pull/57/files?w=1
https://github.com/jbosstools/jbosstools-build/pull/229/files?w=1
https://github.com/jbosstools/jbosstools-target-platforms/pull/226?w=1
https://github.com/jbosstools/jbosstools-discovery/pull/334/files?w=1

Once those are all built (maven clean install -U), you can then verify it works with:

{code}
export JAVA_HOME=/opt/sun-java2-8.0/
echo $JAVA_HOME

cd ~/tru/jbosstools-target-platforms
~/tru/jbosstools-build-ci/util/verifyTarget.sh -x -b `pwd` -p jbosstools
~/tru/jbosstools-build-ci/util/verifyTarget.sh -x -b `pwd` -p jbdevstudio

cd ~/tru/jbosstools-discovery
~/tru/jbosstools-build-ci/util/verifyTarget.sh -x -b `pwd` -p jbtcentral -u http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.60.1.AM1-SNAPSHOT/,http://download.jboss.org/jbosstools/neon/snapshots/updates/core/master/
{code}

So, yeah, the problem is that with provisional APIs (0.x) there's no guarantee that 0.26 and 0.25 will play nicely together. Solution: we move to 0.26, as you suggested. The above PRs let us move to 0.26.0-SNAPSHOT however, if we want to move up sooner. 


was (Author: nickboldt):
PRs to move to 0.26.0-SNAPSHOT in maven-plugins, parent pom and discovery (to be applied in next sprint!):

https://github.com/jbosstools/jbosstools-maven-plugins/pull/57/files?w=1
https://github.com/jbosstools/jbosstools-build/pull/229/files?w=1
https://github.com/jbosstools/jbosstools-target-platforms/pull/226?w=1
https://github.com/jbosstools/jbosstools-discovery/pull/334/files?w=1

Once those are all built (maven clean install -U), you can then verify it works with:

{code}
export JAVA_HOME=/opt/sun-java2-8.0/
echo $JAVA_HOME

cd ~/tru/jbosstools-target-platforms
~/tru/jbosstools-build-ci/util/verifyTarget.sh -x -b `pwd` -p jbosstools
~/tru/jbosstools-build-ci/util/verifyTarget.sh -x -b `pwd` -p jbdevstudio

cd ~/tru/jbosstools-discovery
~/tru/jbosstools-build-ci/util/verifyTarget.sh -x -b `pwd` -p jbtcentral -u http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.60.1.AM1-SNAPSHOT/,http://download.jboss.org/jbosstools/neon/snapshots/updates/core/master/
{code}

So, yeah, the problem is that with provisional APIs (0.x) there's no guarantee that 0.26 and 0.25 will play nicely together. Solution: we move to 0.26, as you suggested. The above PRs let us move to 0.26.0-SNAPSHOT however, if we want to move up sooner. 

> Need better duplicate IU detection when validating target platforms
> -------------------------------------------------------------------
>
>                 Key: JBIDE-22673
>                 URL: https://issues.jboss.org/browse/JBIDE-22673
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build, target-platform, upstream
>    Affects Versions: 4.4.0.Final
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.4.1.AM3
>
>         Attachments: verify-log.txt
>
>
> As discussed in JBIDE-22633, we have no way of knowing when the target platform SHOULD contain duplicate IUs, and when it should not.
> {quote}Problem is there's no way to identify easily which dupes are OK and which are not. I suppose I could crack open all the jars and see which are singletons...?
> Or add a whitelist?{quote}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)