[jbosstools-issues] [JBoss JIRA] (JBIDE-22694) Environment Var Wizard: Improve deletion of environment variables

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270896#comment-13270896 ] 

Andre Dietisheim edited comment on JBIDE-22694 at 7/26/16 6:16 PM:
-------------------------------------------------------------------

I believe that the 2 usecases where the user hits "Delete" by mistaken can be easily handled with a customary "Are you sure?" dialog. It can can get annoying though if we dont offer deletion of multiple entries. But to me the dialog is more "usual"/"familiar" than the [deleted] prefix.
I agree that directly deleting entries would then in consequence mean that we would have to reinsert (deleted) entries in the  table and they would somehow "magically" reappear. Here too we could improve the situation by informing the user about the changes that will be applied when he hits "Reset" (and ask him to confirm). I believe that this matches git since both apply changes directly and only show differences upon request.
There also is another behaviour that feels inconsistent to me. We only have the [deleted] prefix for variables that are loaded from the server. If you add a variable and, a few seconds later delete it (without exiting the wizard), the variable disappears instantly. It wont get prefixed.
Deleting directly seems far more familiar to me, but I might still miss something?


was (Author: adietish):
I believe that the 2 usecases where the user hits "Delete" by mistaken can be easily handled with a customary "Are you sure?" dialog. It can can get annoying though if we dont offer deletion of multiple entries. But to me the dialog is more "usual"/"familiar" than the [deleted] prefix.
I agree that directly deleting entries would then in consequence mean that we would have to reinsert (deleted) entries in the  table and they would somehow "magically" reappear. Here too we could improve the situation by informing the user about the changes that will be applied when he hits "Reset" (and ask him to confirm). I believe that this matches git since both apply changes directly and only show differences upon request.
Deleting directly seems far more familiar to me, but I might still miss something?

> Environment Var Wizard: Improve deletion of environment variables
> -----------------------------------------------------------------
>
>                 Key: JBIDE-22694
>                 URL: https://issues.jboss.org/browse/JBIDE-22694
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.1.AM1
>            Reporter: Marián Labuda
>              Labels: env_var_wizard, openshift_v3
>
> Deletion of environment variable does not match user expectation. If I delete an environment variable which has been added in earlier opened and closed Env. Var wizard, this variable has prefix [deleted]. I don't think this is good practice, we should be consistent across all wizards and dialog, so once user select an env var in table and push Delete button, value should be removed from the table. No labelling should be done here, the table should reflect real current state of environment variable (what it is gonna look like once I hit Finish button).



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)