[jbosstools-issues] [JBoss JIRA] (JBIDE-22694) Environment Var Wizard: Improve deletion of environment variables

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270922#comment-13270922 ] 

Viacheslav Kabanovich edited comment on JBIDE-22694 at 7/26/16 9:46 PM:
------------------------------------------------------------------------

[~adietish], could we combine different viewpoints by adding a checkbox 'Show deleted items' that itself will be enabled (or even visible) only when user deleted some items? Let it be unchecked by default, with [deleted] prefix not surprising anyone, just its enablement already will remind user that there are deleted items and he can see them, and by selecting the checkbox user will be quite prepared to face a surprise.

The other approach would be a full-scaled undo/redo menu, but that is too much for a simple dialog. Buttons 'Reset' and 'Reset All' actually make kind of undo and that is why it seems to me not right to have a change unreachable for 'Reset' - it works only on selection, so that when deleted items are not visible, only 'Reset All' can restore them at the same time rolling back all other changes which for me restricts the functionality.

Concerning items created/deleted in the same session, they are not relevant because such double change does not create difference with the initial state. Both italic font and [deleted] prefix show that difference and that seems consistent to me.

I agree that "Are you sure?" may pop up on delete, but since the deletion is not final until 'Finish', user may be as well spared of reading/thinking/pushing one more button if there is a way to see what he had done (and the proposed checkbox seems a modest way to provide it).


was (Author: scabanovich):
[~adietish], could we combine different viewpoints by adding a checkbox 'Show deleted items' that itself will be enabled (or even visible) only when user selected some items? Let it be unchecked by default, with [deleted] prefix not surprising anyone, just its enablement already will remind user that there are deleted items and he can see them, and by selecting the checkbox user will be quite prepared to face a surprise.

The other approach would be a full-scaled undo/redo menu, but that is too much for a simple dialog. Buttons 'Reset' and 'Reset All' actually make kind of undo and that is why it seems to me not right to have a change unreachable for 'Reset' - it works only on selection, so that when deleted items are not visible, only 'Reset All' can restore them at the same time rolling back all other changes which for me restricts the functionality.

Concerning items created/deleted in the same session, they are not relevant because such double change does not create difference with the initial state. Both italic font and [deleted] prefix show that difference and that seems consistent to me.

I agree that "Are you sure?" may pop up on delete, but since the deletion is not final until 'Finish', user may be as well spared of reading/thinking/pushing one more button if there is a way to see what he had done (and the proposed checkbox seems a modest way to provide it).

> Environment Var Wizard: Improve deletion of environment variables
> -----------------------------------------------------------------
>
>                 Key: JBIDE-22694
>                 URL: https://issues.jboss.org/browse/JBIDE-22694
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.1.AM1
>            Reporter: Marián Labuda
>              Labels: env_var_wizard, openshift_v3
>             Fix For: 4.4.1.Final
>
>
> Deletion of environment variable does not match user expectation. If I delete an environment variable which has been added in earlier opened and closed Env. Var wizard, this variable has prefix [deleted]. I don't think this is good practice, we should be consistent across all wizards and dialog, so once user select an env var in table and push Delete button, value should be removed from the table. No labelling should be done here, the table should reflect real current state of environment variable (what it is gonna look like once I hit Finish button).



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)