[jbosstools-issues] [JBoss JIRA] (JBIDE-22446) Release process should disallow inclusion of snapshots artifacts

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271654#comment-13271654 ] 

Nick Boldt edited comment on JBIDE-22446 at 7/27/16 4:54 PM:
-------------------------------------------------------------

PRs to enable builds to fail if BUILD_ALIAS = Final and there's a SNAPSHOT dependency being used (as a property in the project's poms).

https://github.com/jbosstools/jbosstools-build-ci/pull/149
https://github.com/jbosstools/jbosstools-build/pull/230

[~jeffmaury] [~mickael_istria] [~akazakov] WDYT?

To test this, you need to apply the above projects, then apply this patch:

{code}
$➔ gd
diff --git a/plugins/org.jboss.tools.openshift.client/pom.xml b/plugins/org.jboss.tools.openshift.client/pom.xml
index 6fe1b3f..6e36d0d 100644
--- a/plugins/org.jboss.tools.openshift.client/pom.xml
+++ b/plugins/org.jboss.tools.openshift.client/pom.xml
@@ -23,6 +23,7 @@
                <commons-codec.version>1.6</commons-codec.version>
                <commons-lang.version>2.6</commons-lang.version>
                <commons-io.version>2.1</commons-io.version>
+               <BUILD_ALIAS>Final</BUILD_ALIAS>
        </properties>
{code}

Then you should see something like this when building the openshift.client plugin:

{code}
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-no-snapshots) @ org.jboss.tools.openshift.client ---
[ERROR] Found property openshift-restclient-java.version = 5.0.0-SNAPSHOT
[INFO] Found property BUILD_ALIAS = Final
[WARNING] Rule 0: org.jboss.tools.releng.NoSnapshotsAllowed failed with message:

When BUILD_ALIAS (Final) matches /Final|GA/, cannot include SNAPSHOT dependencies.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-no-snapshots) on project org.jboss.tools.openshift.client: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed.
{code}


was (Author: nickboldt):
PRs to enable builds to fail if BUILD_ALIAS = Final and there's a SNAPSHOT dependency being used (as a property in the project's poms).

https://github.com/jbosstools/jbosstools-build-ci/pull/149
https://github.com/jbosstools/jbosstools-build/pull/230

[~jeffmaury] [~mickael_istria] [~akazakov] WDYT?

To test this, you need to apply the above projects, then apply this patch:

{code}
$➔ gd
diff --git a/plugins/org.jboss.tools.openshift.client/pom.xml b/plugins/org.jboss.tools.openshift.client/pom.xml
index 6fe1b3f..6e36d0d 100644
--- a/plugins/org.jboss.tools.openshift.client/pom.xml
+++ b/plugins/org.jboss.tools.openshift.client/pom.xml
@@ -23,6 +23,7 @@
                <commons-codec.version>1.6</commons-codec.version>
                <commons-lang.version>2.6</commons-lang.version>
                <commons-io.version>2.1</commons-io.version>
+               <BUILD_ALIAS>Final</BUILD_ALIAS>
        </properties>
{code}

> Release process should disallow inclusion of snapshots artifacts
> ----------------------------------------------------------------
>
>                 Key: JBIDE-22446
>                 URL: https://issues.jboss.org/browse/JBIDE-22446
>             Project: Tools (JBoss Tools)
>          Issue Type: Release
>          Components: build
>    Affects Versions: 4.4.0.Alpha2
>            Reporter: Jeff MAURY
>            Assignee: Nick Boldt
>             Fix For: 4.4.1.AM3
>
>
> 4.4.0.Alpha2 was generated with a SNAPSHOT dependency. This should be avoided in future releases even for Alpha ones
> Update: This issues is for adding some automated test/check to detect situation when our release includes a snapshot dependency.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)