[jbosstools-issues] [JBoss JIRA] (JBIDE-22848) Application Wizard: NPE is thrown when closing the wizard and Create OpenShift Project shell
Viacheslav Kabanovich (JIRA)
issues at jboss.org
Wed Jul 27 21:07:00 EDT 2016
[ https://issues.jboss.org/browse/JBIDE-22848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271701#comment-13271701 ]
Viacheslav Kabanovich edited comment on JBIDE-22848 at 7/27/16 9:06 PM:
------------------------------------------------------------------------
When started from explorer, New Project wizard is started from the context of setConnection() method, cancelling closes wizard and disposes resources, but there is one more line in setConnection() which of course fails. Check for null is enough. [~fbricon], please take a look t the pull request.
Concerning closing the wizard after cancel when started from the explorer and not closing it when started not from the explorer, the logic behind it is this: When started from explorer from a selected connection, the wizard is initialized with it and does not have 'Sign in' page, so that cancelling creation of a required project he refuses to continue. If he wants another connection, he can select it in the explorer and start wizard again. When started from the global menu (or central), user first selects a connection, so if on the next page he refuses creation of a project, he still should have the opportunity to return to the 'Sign in' page and change the selected connection. This logic is implemented long ago.
was (Author: scabanovich):
When started from explorer, New Project wizard is started from the context of setConnection() method, cancelling closes wizard and disposes resources, but there is one more line in setConnection() which of course fails. Check for null is enough.
> Application Wizard: NPE is thrown when closing the wizard and Create OpenShift Project shell
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-22848
> URL: https://issues.jboss.org/browse/JBIDE-22848
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Assignee: Viacheslav Kabanovich
> Labels: application_wizard, openshift_v3
>
> There is a prompt to create a new project, if there is no project under an OpenShift 3 connection and New OpenShift Application wizard is opened. If I close popped up shell Create OpenShift Project, also New App wizard is closed and following NPE is shown. This is happening only when opening the wizard through context menu in OpenShift Explorer. Wizards opened via central/shell menu leave New App wizard opened upon cancellation/closing of Create OpenShift Project shell.
> {code}
> org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:64)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:282)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:264)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
> at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:454)
> at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem$3.handleEvent(AbstractContributionItem.java:482)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5219)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1340)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4553)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4143)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1492)
> Caused by: java.lang.NullPointerException
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizard.setConnection(NewApplicationWizard.java:292)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizard.init(NewApplicationWizard.java:98)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:281)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
> at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:34)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> ... 37 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
More information about the jbosstools-issues
mailing list