[jbosstools-issues] [JBoss JIRA] (JBIDE-20026) Explorer, Connection wizard: create new connection should default to OpenShift v3 type connection

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247289#comment-13247289 ] 

Andre Dietisheim edited comment on JBIDE-20026 at 6/2/16 4:15 PM:
------------------------------------------------------------------

[~scabanovich] thanks for the PR, but as discussed with [~fbricon] we could select the connection type of the connection that was last used. The last used connection is available from ConnectionsRegistry#getRecentConnection. To set it's type to the connection type in the connection wizard you can get the matching IConnectionFactory from ConnectionsFactory#getByConnection.
The persistence is not implemented and handling of the most recently used connection is incorrect, it will store the most recently created connection (not the most recently used one).
{quote}
(10:09:01 PM) adietisheim: slava_: i see the wizard calling the model in ConnectionWizardPage#onPageDeactivated
(10:09:22 PM) adietisheim: slava_: but the code in the model to persist it via ConnectionsRegistry (that has the impl) is commented
(10:09:35 PM) adietisheim: slava_: so I'd think that it's not being persisted, no
(10:10:10 PM) adietisheim: ConnectionsWizardPageModel#saveRecentConnection is commented
(10:11:57 PM) adietisheim: ah, persistence isnt impl'd at all, code is only holding it for the session. But the conn page isnt even calling it 
(10:12:56 PM) adietisheim: but recentConnection is set when a new conn is created
(10:13:06 PM) adietisheim: so the logic is bullock at best
(10:13:24 PM) adietisheim: it's not the most recently used, but the most recently created connection
(10:13:42 PM) adietisheim: and then only for the current Eclipse session
{quote}


was (Author: adietish):
[~scabanovich] thanks for the PR, but as discussed with [~fbricon] we could select the connection type of the connection that was last used. The last used connection is available from ConnectionsRegistry#getRecentConnection. To set it's type to the connection type in the connection wizard you can get the matching IConnectionFactory from ConnectionsFactory#getByConnection.
The connection wizard isnt saving the most recently used connection though. The code for it is commented, while the ConnectionsRegistry has the persistence implemented.
But this isnt urgent for 4.4.0.Final

> Explorer, Connection wizard: create new connection should default to OpenShift v3 type connection
> -------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-20026
>                 URL: https://issues.jboss.org/browse/JBIDE-20026
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Andre Dietisheim
>            Priority: Minor
>              Labels: connection_wizard, openshift_v3
>             Fix For: 4.4.x
>
>         Attachments: new-connection-openshift-v2.png
>
>
> Steps to reproduce:
> # ASSERT: make sure that you have a connection to a v3 server
> # EXEC: in explorer: select your v3 connection and open up the context menu, select "New"->"Connection"
> # ASSERT: The connection wizard pops up with <New Connection> preselected so that you can create a new connection
> Result:
> The suggested connection type is "OpenShift v2"
> !new-connection-openshift-v2.png!
> Expected result:
> The suggested connection type should be "OpenShift v3"



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)