[jbosstools-issues] [JBoss JIRA] (JBIDE-22548) Fix remaining CDK names inconsistencies

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249151#comment-13249151 ] 

Rob Stryker commented on JBIDE-22548:
-------------------------------------

Item 1) seems to be caused by a wrong string.  Oops.

Item 2) is a regression caused by my changes trying to work around an upstream issue:  https://bugs.eclipse.org/bugs/show_bug.cgi?id=481726

Sucks.  

Opened https://github.com/jbosstools/jbosstools-openshift/pull/1216

> Fix remaining CDK names inconsistencies
> ---------------------------------------
>
>                 Key: JBIDE-22548
>                 URL: https://issues.jboss.org/browse/JBIDE-22548
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.4.0.Final
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>
> This is a follow up of JBIDE-22431 . There are some remaining things to be fixed.
> 1. Alexey asked for the server adapter to be renamed to "Red Hat Container Development Kit" but it's now "Red Hat Container Development Kit Support". While it makes sense to have "Support" in the feature/plugin name, I don't think it makes sense for the server adapter type or the server name once it's created. So please drop the Support.
> 2. Runtime detection now uses the name of "Container Development Environment". This is inconsistent with creating the server adapter manually. Some time ago we tried to unify this - EAP now has the same names both when created via runtime detection or manually (default name). So if we really want to use the CDE thing (which I'm not a fan of, but whatever), I suggest we use this as the default name when creating a CDK adapter manually. But the adapter type should probably still be "Red Hat Container Development Kit" (no Support)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)