[jbosstools-issues] [JBoss JIRA] (JBIDE-21205) Modify runtime detection to ensure a detector is only asked to initialize runtime definitions it created

[Radim Hopp (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252081#comment-13252081 ] 

Radim Hopp commented on JBIDE-21205:
------------------------------------

Hi [~rob.stryker], could you please provide some steps to verify?

> Modify runtime detection to ensure a detector is only asked to initialize runtime definitions it created
> --------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21205
>                 URL: https://issues.jboss.org/browse/JBIDE-21205
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime-detection
>    Affects Versions: 4.3.0.Beta2
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>            Priority: Minor
>             Fix For: 4.4.0.Alpha1
>
>
> See https://issues.jboss.org/browse/JBIDE-21193 for some background. 
> A runtime detector is asked to initialize all RuntimeDefinition objects, not just ones it created.  While this "works" if you expect a detector to know all type-strings that it creates RuntimeDefinition objects using, it is still less than optimal and the workflow is a bit counter-intuitive. 
> Suggestion is to add a new constructor to RuntimeDefinition and add abstract method for creating those definitions to AbstractRuntimeDetectorDelegate  to instantiate these definitions. 
> Care should be taken since this is all public API and used in Fuse, cdk, servertools, and other locations. It may not be possible to compel consumers to use the new API at all, and so the benefit may be zero. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)