[jbosstools-issues] [JBoss JIRA] (JBIDE-22656) Related tag background becomes misplaced when typing

[Daniel Dekany (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257086#comment-13257086 ] 

Daniel Dekany commented on JBIDE-22656:
---------------------------------------

Note that I have started working on this before you have assigned it to yourself. I'm just saying to avoid the unlikely situation that we both work on the same thing. (I will see tomorrow if my approach will work at all.)

> Related tag background becomes misplaced when typing
> ----------------------------------------------------
>
>                 Key: JBIDE-22656
>                 URL: https://issues.jboss.org/browse/JBIDE-22656
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: freemarker
>            Reporter: Daniel Dekany
>            Assignee: Alexey Kazakov
>             Fix For: 4.4.x
>
>
> When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags, like {{<#else>}} and {{</#if>}}, is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the colored sections after it will become outdated, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)