[jbosstools-issues] [JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258754#comment-13258754 ] 

Nick Boldt edited comment on JBIDE-13671 at 6/29/16 12:29 PM:
--------------------------------------------------------------

Using these two PRs [1], [2], here's what happens in Base when we switch to jgit.

* Before, AM1 prefix is seen. After, only the timestamp of the last change in git (or local dirty change, for foundation.core) is seen:
!base-before-after-jgit.png|thumbnail!

[1] https://github.com/jbosstools/jbosstools-build/pull/223
[2] https://github.com/jbosstools/jbosstools-base/pull/514

And, here's some examples of what happens in Arquillian when comparing a clean jgit-based build with a dirty-workspace version of the same build, to show that even without committing changes, your LOCALLY built plugins/features will be correctly upversioned so you can do install tests.

* left side, after changing to jgit timestamps. right side, after making a change in the local git workspace & rebuilding:
!arq-dirty-workspace-compare1.png|thumbnail!
* detail of the feature.source feature.xml files, before and after the dirty change. We see that the correctly versioned new plugin appears in the feature, and the feature version is increased too, even though the change is only in the plugin.
!arq-dirty-workspace-compare1.png|thumbnail!

* For a bigger change like a refactoring, we see now that the .java and .class files are updated, and again the plugins are upversioned:
!arq-dirty-workspace-compare3-bigger-change.png|thumbnail!
* And as expected the features are also upversioned for the change:
!arq-dirty-workspace-compare4-bigger-change.png|thumbnail!


was (Author: nickboldt):
Using these two PRs [1], [2], here's what happens in Base when we switch to jgit:

!base-before-after-jgit.png|thumbnail!

[1] https://github.com/jbosstools/jbosstools-build/pull/223
[2] https://github.com/jbosstools/jbosstools-base/pull/514

And, here's some examples of what happens in Arquillian when comparing a clean jgit-based build with a dirty-workspace version of the same build, to show that even without committing changes, your LOCALLY built plugins/features will be correctly upversioned so you can do install tests.

!arq-dirty-workspace-compare1.png|thumbnail!

!arq-dirty-workspace-compare1.png|thumbnail!

!arq-dirty-workspace-compare3-bigger-change.png|thumbnail!

!arq-dirty-workspace-compare4-bigger-change.png|thumbnail!

> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
>                 Key: JBIDE-13671
>                 URL: https://issues.jboss.org/browse/JBIDE-13671
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Optional
>             Fix For: 4.4.1.AM1
>
>         Attachments: arq-dirty-workspace-compare1.png, arq-dirty-workspace-compare2.png, arq-dirty-workspace-compare3-bigger-change.png, arq-dirty-workspace-compare4-bigger-change.png, base-before-after-jgit.png, jbide13671-before-and-after.png, server-before-after-jgit-3-different-timestamps.png, server-before-after-jgit-4-different-timestamps-features.png, server-before-after-jgit-dirty-workspace-upversioned-features.png, server-before-after-jgit-dirty-workspace-upversioned-plugin-with-change.png
>
>
> This needs to be added to master parent pom:
> {code}
>        <plugin>
>           <groupId>org.eclipse.tycho</groupId>
>           <artifactId>tycho-packaging-plugin</artifactId>
>           <version>${tycho.version}</version>
>           <dependencies>
>             <dependency>
>               <groupId>org.eclipse.tycho.extras</groupId>
>               <artifactId>tycho-buildtimestamp-jgit</artifactId>
>               <version>${tycho-extras.version}</version>
>             </dependency>
>           </dependencies>
>           <configuration>
>             <strictBinIncludes>false</strictBinIncludes>
>             <format>'v'yyyyMMdd-HHmm</format>
>             <timestampProvider>jgit</timestampProvider>
>             <jgit.ignore>
>             </jgit.ignore>
>           </configuration>
>         </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)