[jbosstools-issues] [JBoss JIRA] (JBIDE-21744) cdk-created docker connection can have wrong name if you have multiple cdk server adapters

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171475#comment-13171475 ] 

Rob Stryker commented on JBIDE-21744:
-------------------------------------

If the host / port are the same, do you really need an additional connection with the same host/port?  It's clear you can't have two cdk's started responding on the same host/port, and so only one of the connections would be valid. 

Take the following situation:   same two cdk's  (raw / hardys).  Imagine the tools code creates two separate connections upon startup of the respective cdks. We now have 'hardys cdk docker connection'  and  'raw cdk docker connection'.  

Both connections in the docker explorer would be able to be expanded, even if only one cdk is started. If raw cdk is started,  both 'raw cdk docker connection'  and  'hardys cdk docker connection' can be expanded. 

The user may notice his 'hardys cdk docker connection' can expand, even when the 'hardys cdk' isn't started. Users may then get confused, and think they're inspecting the hardys cdk docker containers, when in fact they're inspecting the raw cdk. 

So this also doesn't make the situation better. 

> cdk-created docker connection can have wrong name if you have multiple cdk server adapters
> ------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21744
>                 URL: https://issues.jboss.org/browse/JBIDE-21744
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.3.1.CR1
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>
> I noticed that if I have two cdk server adapters, start the first one, stop it, start the second, then docker explorer will only show a connection of the first server name, not the second.
> This is probably because the connection will stay there after the first server start and on second server start, the tooling only checks if the docker host url matches. If it does, it will just reuse it.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)