[jbosstools-issues] [JBoss JIRA] (JBIDE-21818) Too large margins in wizards

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172284#comment-13172284 ] 

Viacheslav Kabanovich edited comment on JBIDE-21818 at 3/4/16 3:27 PM:
-----------------------------------------------------------------------

Many wizard pages inherited from AbstractOpenShiftWizardPage, in doCreateControls method have first line like
{code}
	GridLayoutFactory.fillDefaults().margins(10, 10).applyTo(parent);
{code}
that sets margin 10 (default is 5) in most pages, in some 6, in some 1. Evidently, it looks differently on different OS. I do see on the screenshot attached that margins are too large, but when I look at the same page in my Ubuntu, it does not causes that feeling, though comparing to other Eclipse wizards, the margin is larger. So, if adjusted to look perfect on one OS, it can look worse on another. Then, could it be better just to stick to default 5 for margin in all wizards?


was (Author: scabanovich):
Many wizard pages inherited from AbstractOpenShiftWizardPage, in doCreateControls method have first line like
{code}
	GridLayoutFactory.fillDefaults().margins(10, 10).applyTo(parent);
{code}
that sets margin 10 (default is 5) in most pages, in some 6, in some 1. Evidently, it looks differently on different OS. I do see on the screenshot attached that margins are too large, but when I look at the same page in my Ubuntu, it does not causes that feeling, though comparing to other Eclipse wizards, the margin is larger. So, if adjusted to look perfect on one OS, it can look worth on another. Then, could it be better just to stick to default 5 for margin in all wizards?

> Too large margins in wizards
> ----------------------------
>
>                 Key: JBIDE-21818
>                 URL: https://issues.jboss.org/browse/JBIDE-21818
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.1.Beta2
>            Reporter: Xavier Coulon
>             Fix For: 4.4.0.Alpha1
>
>         Attachments: Screenshot 2016-03-04 11.19.59.png
>
>
> Some wizard have too large margins, wasting space and making them inconsistent with the other Eclipse wizards in general.
> See attached screenshot as an example 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)