[jbosstools-issues] [JBoss JIRA] (JBIDE-21828) OpenShift Explorer view flickers when refreshing a service

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174082#comment-13174082 ] 

Andre Dietisheim edited comment on JBIDE-21828 at 3/9/16 5:27 AM:
------------------------------------------------------------------

[~scabanovich] I partly agree on your 1st comment that initially events should not be fired: look at how most observable frameworks work: they always fire, they wont differ if it's a 1st call or a subsequent one. The firing though wont be executed on a more general condition (not based on the fact if this is the first or 2nd, 3rd, etc. call): the firing wont happen if there's no change in the values (see for instance the firing code in PropertyChangeSupport which does not execute the firing if there's no change btw. oldValue and newValue).


was (Author: adietish):
[~scabanovich] I partly agree on your 1st comment that initially events should not be fired: look at how most observable frameworks work: they always fire, they wont differ if it's a 1st call or a subsequent one. The firing though wont be executed on a more general condition: the firing wont happen if there's no change in the values (see for instance the firing code in PropertyChangeSupport which does not execute the firing if there's no change btw. oldValue and newValue).

> OpenShift Explorer view flickers when refreshing a service
> ----------------------------------------------------------
>
>                 Key: JBIDE-21828
>                 URL: https://issues.jboss.org/browse/JBIDE-21828
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta2
>            Reporter: Xavier Coulon
>         Attachments: Screenshot 2016-03-08 10.32.39.png
>
>
> When calling the "Refresh" command on a service, the tree view flickers because of too many refresh calls.
> Adding some traces revealed 25 calls to {{BaseExplorerContentProvider#refreshViewer(Object)}}, which seems way too much for a service with a single pod.
> Attachement: screenshot of the OpenShift Server view, showing 2 projects, one of which has 3 services.
> Custom/added logs in the console:
> {code}
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/mongodb
> Refreshing viewer from sample/mongodb
> Refreshing viewer from sample/mongodb
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/jee-sample
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from sample/nodejs-mongodb-example
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> Refreshing viewer from org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectUIModel at 431dafbc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)