[jbosstools-issues] [JBoss JIRA] (JBIDE-21905) Server adapter states don't reflect any real state

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-21905.
---------------------------------
    Resolution: Done


There are a number of issues with this, but I've done my best to make sure the state matches as best as expected.  The fact is that the openshift server adapter actually won't start or stop the openshift service, and is primarily used to control other parts of WTP, such as whether auto-publish is enabled. 

I've tried to ensure that when the user starts the server, we at least try to access the service, and so we don't end up with a failure and still have the server in state 'started'. 

However, state 'stopped' will probably never be accurate. Our initial suggestion was to not even allow the user to stop the server at all (even just cosmetically), but it turns out being able to 'stop' it was a requirement for our remote debugger logic. 

Hopefully the new logic will be more to your liking. 

> Server adapter states don't reflect any real state
> --------------------------------------------------
>
>                 Key: JBIDE-21905
>                 URL: https://issues.jboss.org/browse/JBIDE-21905
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.CR1
>            Reporter: Jan Richter
>            Assignee: Rob Stryker
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.3.1.CR1
>
>
> Having OS server adapters showing started/stopped states is quite perplexing, because they are completely arbitrary.
> For example, I can click start on a stopped server with no connection, then just cancel the connection dialog - it throws an error, but it proceeds to started state anyway.
> It is meaningless to have different states, when their only function is to predend the server is in some state. Plus it introduces steps like the 'stop server before deleting' dialog.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)