[jbosstools-issues] [JBoss JIRA] (JBIDE-21453) Server Adapter: use rsync flag instead of local filtered-copy

[Xavier Coulon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181507#comment-13181507 ] 

Xavier Coulon edited comment on JBIDE-21453 at 3/23/16 1:55 PM:
----------------------------------------------------------------

so, after a bit of investigation, the {{oc rsync}} command only supports a single {{--exclude=PATTERN}} argument. But it also supports the {{--no-perms}} flag, which according to the CLI help, can be set to {{true}} to avoid transfering permissions.

As discussed with [~adietish], the solution to fix this issue would be:
- stop doing the pod->local rsync. It was initially used to retrieve all files from the pod with their permissions and becomes useless now.
- run the 'oc rsync' command from local->pod using the {{--exclude='.git'}} flag to avoid pushing the changes in the {{.git}} folder (only), assuming this is the largest folder that does not need to be rsync'ed.

I also opened https://github.com/openshift/origin/issues/8223 to request support for the {{--exclude-from=FILE}} option in the command line, to be able to exclude multiple files/folders during the rsync (.svn, .git, etc)


was (Author: xcoulon):
so, after a bit of investigation, the {{oc rsync}} command only supports a single {{--exclude=PATTERN}} argument. But it also supports the {{--no-perms}} flag, which according to the CLI help, can be set to {{true}} to avoid transfering permissions.

As discussed with [~adietish], the solution to fix this issue would be:
- stop doing the pod->local rsync. It was initially used to retrieve all files from the pod with their permissions and becomes useless now.
- run the 'oc rsync' command from local->pod using the {{--exclude='.git'}} flag to avoid pushing the changes in the {{.git}} folder (only), assuming this is the largest folder that does not need to be rsync'ed.

> Server Adapter: use rsync flag instead of local filtered-copy
> -------------------------------------------------------------
>
>                 Key: JBIDE-21453
>                 URL: https://issues.jboss.org/browse/JBIDE-21453
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Andre Dietisheim
>            Assignee: Xavier Coulon
>             Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> With https://github.com/openshift/origin/issues/6143 *oc rsync* now allows specific white-listed flag to be used.
> Our current implementation works around this by doing a local copy where excluded bits are filtered (not copied). We need to use exclusion flags if available.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)