[jbosstools-issues] [JBoss JIRA] (JBIDE-21603) CDK Runtime is useless stub and should be removed

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-21603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-21603.
---------------------------------
    Resolution: Done


removed 

{code}
commit 3279fd324c37ea45e0cac8c4570e5bf0a390f3e9
Author: Rob Stryker <rob at oxbeef.net>
Date:   Wed Mar 23 19:17:04 2016 -0400

    JBIDE-21603 - removing useless ui element for cdk runtime
    one-line fix that just sets runtime=false

diff --git a/plugins/org.jboss.tools.openshift.cdk.server/plugin.xml b/plugins/org.jboss.tools.openshift.cdk.server/plugin.xml
index a693ce2..25d5aae 100644
--- a/plugins/org.jboss.tools.openshift.cdk.server/plugin.xml
+++ b/plugins/org.jboss.tools.openshift.cdk.server/plugin.xml
@@ -13,7 +13,7 @@
             initialState="stopped"
             launchConfigId="org.jboss.tools.openshift.cdk.server.core.internal.behaviour.launchType"
             launchModes="run"
-            runtime="true"
+            runtime="false"
             runtimeTypeId="org.jboss.tools.openshift.cdk.server.runtime.type"
             startBeforePublish="false"
             startTimeout="1800000"
{code}


> CDK Runtime is useless stub and should be removed
> -------------------------------------------------
>
>                 Key: JBIDE-21603
>                 URL: https://issues.jboss.org/browse/JBIDE-21603
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk
>    Affects Versions: 4.3.1.Beta2
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>             Fix For: 4.3.1.CR1
>
>
> When you open the New Server dialog and want to create a new CDK server while there is already one existing, it will preselect the existing runtime. There is an "Add" button to add a new runtime, but it doesn't work - when you click it, nothing happens.
> 1. Create a cdk server
> 2. Open the new server dialog again
> 3. For server type, select CDK
> 4. The server runtime env field will show the existing runtime. Click Add next to the field to create a new runtime - nothing happens
> At first, I thought it was just this. But now I'm confused what the design really is. At first it seemed you just added the notion of runtimes just like we use them for JBoss AS / WildFly / EAP. Then it seemed you dropped runtimes and just used servers. But now it seems there is still a runtime displayed in the server editor.
> When I first created a cdk server manually (this was cdk beta4), it has its own runtime. Then I used runtime detection to add another cdk server (this was openshift-vagrant git repo), but in server editor, it shows the Beta4 runtime is used and there is no way to change it. Then in preferences -> Server -> Runtime Environments, you can see the one runtime, but you can't edit it. And when you want to add a new one, there is no CDK type in the new runtime dialog.
> So it seems we're somewhere halfway between not using runtimes at all and using them to some degree.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)