[jbosstools-issues] [JBoss JIRA] (JBIDE-21996) Order of project in New OS3 Server Adapter wizard could be better

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183607#comment-13183607 ] 

Viacheslav Kabanovich edited comment on JBIDE-21996 at 3/30/16 1:29 AM:
------------------------------------------------------------------------

That is what I have found. 
1. Sorter for services tree viewer is ViewerSorter.
2. ViewerSorter compares items by label (in ViewerComparator.compare)
3. Label is received from label provider but only if it implements ILabelProvider, otherwise it just calls toString() on item.
4. Label provider for services tree viewer is ServicesViewLabelProvider that extends StyledCellLabelProvider which allows to efficiently update viewer cell but which _does not_ implement ILabelProvider.
5. So, sorter sorts by IProject.toString() which is implemented by calling toJson().

Proposed solution: override method ViewerComparator.compare(Viewer viewer, Object e1, Object e2).
[~adietish], please take a look at the pull request.


was (Author: scabanovich):
That is what I have found. 
1. Sorter for services tree viewer is ViewerSorter.
2. ViewerSorter compares items by label (in ViewerComparator.compare)
3. Label is received from label provider but only if it implements ILabelProvider, otherwise it just calls toString() on item.
4. Label provider for services tree viewer is ServicesViewLabelProvider that extends StyledCellLabelProvider which allows to efficiently update viewer cell but which _does not_ implement ILabelProvider.
5. So, sorter sorts by IProject.toString() which is implemented by calling toJson().

Proposed solution: override method ViewerComparator.compare(Viewer viewer, Object e1, Object e2).

> Order of project in New OS3 Server Adapter wizard could be better
> -----------------------------------------------------------------
>
>                 Key: JBIDE-21996
>                 URL: https://issues.jboss.org/browse/JBIDE-21996
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Marián Labuda
>            Assignee: Andre Dietisheim
>              Labels: openshift_v3, server_adapter_wizard
>
> With latest changes to New OS3 Server Adapter wizard the current order of projects, listed on wizard page where service selection is done, is a bit strange. At first there are alphanumeric ordered projects with no services and therefore they are not useful for creation of a new OS3 Server Adapter and then there are projects with any service ordered in alphanumberic order. It results in following.
> Assume project aproject with no services, bproject with a service, c project with no services, d project with a service. Order on the wizard page is following:
> a
> c
> b
> d
> I think we are safe not to list projects with no services there or otherwise we should keep alphanumeric order regardless existence of a service under a project.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)