[jbosstools-issues] [JBoss JIRA] (JBIDE-21995) Hostname is set to localhost when prompt for route is checked

[Xavier Coulon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184556#comment-13184556 ] 

Xavier Coulon commented on JBIDE-21995:
---------------------------------------

This [~rob.stryker]'s patch applied, the fix for JBIDE-21994 becomes obsolete because the hostname on the server adapter is properly set, which means that LiveReload can work with this server adapter has with any other one, without any specific behaviour.
I would personally prefer not to patch the LiveReload tooling, unless there was a risk that the hostname would remain to 'localhost', but that would mean that there's no route to get to the service, right ? 

[~fbricon], [~rob.stryker], [~akazakov], thoughts ? 

On the other hand, what would happen if the route was removed or changed ? Should we ask the user to delete and recreate the server adapter ? 

As a last comment, the "Open in Web Browser via LiveReload" fails on the server module because the requested URI includes the module name (which is wrong when there's only one module deployed as ROOT.war)

> Hostname is set to localhost when prompt for route is checked
> -------------------------------------------------------------
>
>                 Key: JBIDE-21995
>                 URL: https://issues.jboss.org/browse/JBIDE-21995
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.CR1
>            Reporter: Marián Labuda
>            Assignee: Rob Stryker
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.3.1.CR1
>
>
> Hostname in Server Editor for an OpenShift 3 application is set to localhost if checkbox "Prompt for route when multiple routes available to show in browser" is checked. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)