[jbosstools-issues] [JBoss JIRA] (JBIDE-13671) Replace build timestamp in qualifier by last-mod-timestamp from git

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199850#comment-13199850 ] 

Nick Boldt commented on JBIDE-13671:
------------------------------------

"If you use a different TP that affects the feature.xml resolution of what the 0.0.0 refers to does it not ? Thus it will behave differently since the content is actually different."

If you mean at install time, yes, but changing the version of the feature.jar won't change that behaviour. We already have this feature-not-a-bug which allows us to change the TP without updating JBDS, or change JBDS without changing the TP. They can move independently and p2 handles it.

If you mean at build time, no, because we don't package our TP artifacts into the features. We only *depend* on them; we do not *include* them. So the depend relationship continues to be to "the version available at build time" rather than "a specific version we've bundled up into this update site".

"why don't we delete the new duplicates ?"

Do you mean we would merge old plugins built a month ago (with the same timestamp/SHA) into a new CI build's update site, rather than using the freshly-rebuilt-from-the-same-SHA ones?

Because... Maven doesn't do that, and if we wanted to write our own "compare with old baseline and copy identically-timestamped IUs into the new CI site" we could. But given the fact that the same sources are used, surely the same output is produced, making the two jars bitwise nearly identical?

"how are you going to support not having a maintanence branch and product branch for developer studio"

When we create the first CR build for 4.4.0.Final / 10.0.0.GA), we would THEN cut a 4.4.x maintenance branch, in order to have a place to work on JBT 4.5 / DS 11. 

But we won't need all the milestoneX (jbosstools-4.3.0.Beta1x, jbosstools-4.3.1.Beta1x, etc.) branches we currently use - all that extra churn and burn goes away in the interest of being more agile.

" if you installed month later you get the new one, but if you update you stay on the old build."

This is only true if the feature versions don't change while the plugin versions DO. But according to Tycho's doc, if a contained plugin changes, so too will the feature version change:

https://wiki.eclipse.org/Tycho/Reproducible_Version_Qualifiers#Feature_version_qualifiers

Oh, and note too:

{quote}Please note that if a feature directly includes bundles or features not part of the same code base but consumed via a target platform, the stability of a reproducible feature version qualifier also depends on the stability of the target platform in addition to the stability of the code base. If a rebuild occurs with a change in target platform, a different feature version qualifier might be generated.{quote}

So... TL;DR, Denis and I both like this idea. 

Only major concern I've seen raised from Max (in March 2013) is "to get rid of snapshot dependencies first - maven deps, parent pom, target platform, maven plugins. Not tycho/p2-deps." I'm not convinced that any of the other concerns raised are real issues, only fears of the unknown. 

So, to address the question of "maven deps, parent pom, target platform, maven plugins", I need more information. Max, can you clarify how changing the plugins/feature versions will impact our existing dependency on these upstream artifacts? 

Further, if we released a parent pom 4.4.0.Final (not snapshot) and allowed no more parent pom changes for the rest of the 4.4.0.x development cycle, would that allay fears? If we do that, then the only way to release new TPs and have them used by devs/Jenkins would be ... commandline flags, which is non-ideal. Open to better ideas - I'm all out. :(





> Replace build timestamp in qualifier by last-mod-timestamp from git
> -------------------------------------------------------------------
>
>                 Key: JBIDE-13671
>                 URL: https://issues.jboss.org/browse/JBIDE-13671
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Optional
>             Fix For: 4.4.0.Alpha2
>
>         Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
>        <plugin>
>           <groupId>org.eclipse.tycho</groupId>
>           <artifactId>tycho-packaging-plugin</artifactId>
>           <version>${tycho.version}</version>
>           <dependencies>
>             <dependency>
>               <groupId>org.eclipse.tycho.extras</groupId>
>               <artifactId>tycho-buildtimestamp-jgit</artifactId>
>               <version>${tycho-extras.version}</version>
>             </dependency>
>           </dependencies>
>           <configuration>
>             <strictBinIncludes>false</strictBinIncludes>
>             <format>'v'yyyyMMdd-HHmm</format>
>             <timestampProvider>jgit</timestampProvider>
>             <jgit.ignore>
>             </jgit.ignore>
>           </configuration>
>         </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)