[jbosstools-issues] [JBoss JIRA] (JBIDE-21228) DeploymentConfig for Deploying a docker image should point the image container to the imagestream

[Jeff Cantrill (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200445#comment-13200445 ] 

Jeff Cantrill commented on JBIDE-21228:
---------------------------------------

I am unable to reproduce this behavior on master using the context menu 'deploy image' from the docker explorer view: https://gist.github.com/jcantrill/4a2db8ace7c08590762f160a87df3e00  If I choose an image and allow the wizard to populate it, I get what is shown in the gist.  If I explicitly add 'docker.io' as the repo (e.g. docker.io/openshift/hello-openshift).  The IS and DC are created with 'docker.io' since looking at the code we explicitly retain the repo.  This is for cases where the repo is not one of the defaults.  IMO this is desired behavior.  If you can list the steps that are different from what I describe here I will continue investigation.  I otherwise believe this is working as I would expect it.  The only obvious thing I can think we may wish to do is whitelist 'docker.io' and remove it if the docker URI includes it.

> DeploymentConfig for Deploying a docker image should point the image container to the imagestream
> -------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21228
>                 URL: https://issues.jboss.org/browse/JBIDE-21228
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Jeff Cantrill
>            Assignee: Jeff Cantrill
>            Priority: Minor
>              Labels: openshift_v3
>             Fix For: 4.4.0.Alpha1
>
>
> Deploying a docker image from a local machine will create resources.  When the image is pushed to OS, the DC should assume it will be namespaced to the same project in which the resources are created. Ref: https://gist.github.com/jcantrill/cb84b919e1a7a4791440#file-gistfile1-txt-L35
> This image was deployed to the 'helloworld' namespace and the image spec should not include the original docker namespace.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)