[jbosstools-issues] [JBoss JIRA] (JBIDE-21657) set up jobs to handle building from PRs

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202939#comment-13202939 ] 

Mickael Istria commented on JBIDE-21657:
----------------------------------------

IMO, the recommended pattern would be something like REPO_NAME__pull-request

On another topic,
Is it necessary to publish e p2 repo for the topic branch? I see the configuration is jbosstools-server__pull-request_master is now much more complicated than a simple "mvn clean verify", introducing an intermediary script to orchestrate Maven ( https://github.com/jbosstools/jbosstools-build-ci/blob/jbosstools-4.4.x/publish/build-jbosstools-component.sh ). Do we need all that complexity? Do all those build flags need to be overriden? Shouldn't we be using the default from pom.xml instead?
It seems to me that at the moment, the request from our dev is only to have "mvn clean verify" running. It seems to me that as part of this issue we're trying to do too much too early.

> set up jobs to handle building from PRs
> ---------------------------------------
>
>                 Key: JBIDE-21657
>                 URL: https://issues.jboss.org/browse/JBIDE-21657
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Critical
>             Fix For: 4.4.0.Alpha2
>
>
> First experimental build:
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.child-sites__pull-request_master/
> Output:
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.earlyaccess-site_master/2016-02-05_16-34-19-B1/all/repo/buildinfo.json
> {code}
>     "revision" : {
>         "HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
>         "currentBranch" : "HEAD",
>         "knownReferences" : [{
>             "name" : "origin",
>             "url" : "git://github.com/jbosstools/jbosstools-build-sites.git",
>             "ref" : "pr/221/merge"
>         }]
>     },
> {code}
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.earlyaccess-site_master/2016-02-05_16-34-19-B1/logs/GIT_REVISION.txt
> {code}
> #Fri Feb 05 16:42:42 EST 2016
> null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> build log:
> {code}
> Started by upstream project "jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number 1
> originally caused by:
>  GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts.
> ...
> Fetching upstream changes from git://github.com/jbosstools/jbosstools-build-sites.git
>  > git -c core.askpass=true fetch --tags --progress git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/*
> Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805 (refs/remotes/origin/pr/221/merge)
>  > git config core.sparsecheckout # timeout=10
>  > git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> vars:
> {code}
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> -DghprbPullId=221
> -Dsha1=origin/pr/221/merge
> "-DghprbPullDescription=GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts." 
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)