[jbosstools-issues] [JBoss JIRA] (JBIDE-21657) set up jobs to handle building from PRs

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238326#comment-13238326 ] 

Nick Boldt commented on JBIDE-21657:
------------------------------------

Well, for the case of the server job, I can only see artifacts for the current build, plus the two successful blue jobs. It's unclear why artifacts were not stored for any of the yellow or red jobs, since "Archive artifacts only if build is successful" is unchecked.

Re: your comment about not wanting a "Swiss Army knife" solution for both PRs and commits, to me it seems easier to have one job config that works for both.

Either you...

* run 3 steps
** (build commit, 
** deploy update site onto download.jboss.org (with automated cleanup) in a /builds/ folder, 
** run tests)

or you... 

* run 3 steps 
** (build PR, 
** deploy PR update site onto download.jboss.org (with automated cleanup) in a /pulls/ folder, 
** run tests)

Why make the config different for a PR vs. a commit, when both uscases can do the same steps and thus keep things simpler?

> set up jobs to handle building from PRs
> ---------------------------------------
>
>                 Key: JBIDE-21657
>                 URL: https://issues.jboss.org/browse/JBIDE-21657
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Critical
>             Fix For: 4.4.0.Alpha2
>
>
> First experimental build:
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.child-sites__pull-request_master/
> Output:
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.earlyaccess-site_master/2016-02-05_16-34-19-B1/all/repo/buildinfo.json
> {code}
>     "revision" : {
>         "HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
>         "currentBranch" : "HEAD",
>         "knownReferences" : [{
>             "name" : "origin",
>             "url" : "git://github.com/jbosstools/jbosstools-build-sites.git",
>             "ref" : "pr/221/merge"
>         }]
>     },
> {code}
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.earlyaccess-site_master/2016-02-05_16-34-19-B1/logs/GIT_REVISION.txt
> {code}
> #Fri Feb 05 16:42:42 EST 2016
> null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> build log:
> {code}
> Started by upstream project "jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number 1
> originally caused by:
>  GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts.
> ...
> Fetching upstream changes from git://github.com/jbosstools/jbosstools-build-sites.git
>  > git -c core.askpass=true fetch --tags --progress git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/*
> Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805 (refs/remotes/origin/pr/221/merge)
>  > git config core.sparsecheckout # timeout=10
>  > git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> vars:
> {code}
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> -DghprbPullId=221
> -Dsha1=origin/pr/221/merge
> "-DghprbPullDescription=GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts." 
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)