[jbosstools-issues] [JBoss JIRA] (JBIDE-21885) Properties: Remove "()" from context-menu name of Start Build

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239682#comment-13239682 ] 

Viacheslav Kabanovich edited comment on JBIDE-21885 at 5/18/16 3:08 PM:
------------------------------------------------------------------------

Addition "()" is made by ParameterizedCommand.getName(String baseName).
And while it tries insert parameter value calling appendParameter(), it accesses Parameterization.getValueName() and then Parameter.getValues(), it fails on creating extension
{code}
(IParameterValues) valuesConfigurationElement
							.createExecutableExtension(ATTRIBUTE_VALUES);
{code}
because we do not have attribute 'values'. So, the CoreException is caught and new ParameterValuesException("Problem creating parameter values", e) is thrown.
Next, ParameterValuesException is caught in Parameterization.appendParameter() and the way it is treated deserves to be studied as an instructing masterpiece:
{code}
		try {
			nameBuffer.append(parameterization.getValueName());
		} catch (final ParameterValuesException e) {
			/*
			 * Just let it go for now. If someone complains we can
			 * add more info later.
			 */
		}
{code}
No more comments are needed. 


was (Author: scabanovich):
Addition "()" is made by ParameterizedCommand.getName(String baseName).

> Properties: Remove "()" from context-menu name of Start Build 
> --------------------------------------------------------------
>
>                 Key: JBIDE-21885
>                 URL: https://issues.jboss.org/browse/JBIDE-21885
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.0.Alpha1
>         Environment:  JBoss OpenShift 3 Tools	3.2.0.Alpha1-v20160316-2139-B1202
> OS: Fedora 22 & Windows 10
>            Reporter: Xia Zhao
>            Assignee: Viacheslav Kabanovich
>            Priority: Minor
>              Labels: openshift_v3
>             Fix For: 4.4.0.Alpha2
>
>         Attachments: build-config-properties-menu.png, start-build.png
>
>
> The  "()" from context-menu name of Start Build should be removed



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)