[jbosstools-issues] [JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

[Andre Dietisheim (JIRA)]

Andre Dietisheim created JBIDE-22426:
----------------------------------------

             Summary: Connection: authorization strategy is always overwritten (in the client) upon #isConnected 
                 Key: JBIDE-22426
                 URL: https://issues.jboss.org/browse/JBIDE-22426
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: openshift
    Affects Versions: 4.4.0.Alpha3
            Reporter: Andre Dietisheim


The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy.

{code:title=Connection#isConnected}
	public boolean isConnected(IProgressMonitor monitor) {
		client.setAuthorizationStrategy(getAuthorizationStrategy());
		try {
{code}

{code:title=Connection#createResource}
	public <T extends IResource> T createResource(T resource) {
		try {
			if(client.getAuthorizationStrategy() == null) {
				client.setAuthorizationStrategy(getAuthorizationStrategy());
			}
			return client.create(resource);
{code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)