[jbosstools-issues] [JBoss JIRA] (JBIDE-22420) Application Wizard: Finish button is still enabled upon selection of a builder image if a template was selected before

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241382#comment-13241382 ] 

Viacheslav Kabanovich commented on JBIDE-22420:
-----------------------------------------------

The Finish button remains enabled because overridden ApplicationSourceListPage.getNextPage() as soon as a template is selected sets 3 pages of 'image flow' as completed, and they remain in that state. Method getNextPage() is called already when wizards updates enablement of the Next button. All these pages override isPageComplete() to return true if a template is selected, so that there should be no need to set them completed in getNextPage().
The second part, why Finish should be disabled for a selected image, but on Next pressed the next page allows to finish even without user input, - is because initialization for the selected image is deferred until Next is pressed. It is done because of performance issues at loading image metadata. Besides, the loading may fail, so that user is informed of it in an error message dialog and wizard does not switch page. If loading was asynchronous on image selection, user experience might be much more weird than just pressing Next while Finish is disabled and getting to the next page with Finish enabled.

> Application Wizard: Finish button is still enabled upon selection of a builder image if a template was selected before
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-22420
>                 URL: https://issues.jboss.org/browse/JBIDE-22420
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.0.Alpha2
>            Reporter: Marián Labuda
>              Labels: application_wizard, openshift_v3
>             Fix For: 4.4.0.Alpha3
>
>
> If I select a template in New OpenShift Application wizard, the Finish button is enabled and it is possible to skip all wizard pages and have created an application. If I select a builder image in the wizard, Finish is disabled (although on the next wizard page it gets enabled even I do not set any other value manually). But having selecting a template at first in the wizard and then selecting a build image, Finish button is still enabled. Click on the button cause NPE with following stack trace:
> {code}Unable to create resources to deploy image null
> java.lang.IllegalArgumentException: newValue is null
> 	at org.jboss.dmr.ModelNode.set(ModelNode.java:499)
> 	at com.openshift.internal.restclient.model.Service.setSelector(Service.java:115)
> 	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.stubService(DeployImageJob.java:254)
> 	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.generateResources(DeployImageJob.java:150)
> 	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.doRun(DeployImageJob.java:99)
> 	at org.jboss.tools.openshift.internal.common.core.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:37)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)