[jbosstools-issues] [JBoss JIRA] (JBIDE-22420) Application Wizard: Finish button is still enabled upon selection of a builder image if a template was selected before

[Andre Dietisheim (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-22420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim updated JBIDE-22420:
-------------------------------------
    Steps to Reproduce: 
# ASSERT: have connection with a project in the openshift explorer
# EXEC: pick New > Application in the context menu of your project
# ASSERT: wizard page with templates and builder images shows up, "Finish" is disabled
# EXEC: select a builder image (entry with a box icon as opposed to a lightning)
# ASSERT: "Finish" stays disabled
# EXEC: select a template (entry with a lightning)
# ASSERT: "Finish" gets enabled
# EXEC: select a builder image

Result:
"Finish" is enabled even though it should be disabled.



> Application Wizard: Finish button is still enabled upon selection of a builder image if a template was selected before
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-22420
>                 URL: https://issues.jboss.org/browse/JBIDE-22420
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.0.Alpha2
>            Reporter: Marián Labuda
>              Labels: application_wizard, openshift_v3
>             Fix For: 4.4.0.Alpha3
>
>
> If I select a template in New OpenShift Application wizard, the Finish button is enabled and it is possible to skip all wizard pages and have created an application. If I select a builder image in the wizard, Finish is disabled (although on the next wizard page it gets enabled even I do not set any other value manually). But having selecting a template at first in the wizard and then selecting a build image, Finish button is still enabled. Click on the button cause NPE with following stack trace:
> {code}Unable to create resources to deploy image null
> java.lang.IllegalArgumentException: newValue is null
> 	at org.jboss.dmr.ModelNode.set(ModelNode.java:499)
> 	at com.openshift.internal.restclient.model.Service.setSelector(Service.java:115)
> 	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.stubService(DeployImageJob.java:254)
> 	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.generateResources(DeployImageJob.java:150)
> 	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.doRun(DeployImageJob.java:99)
> 	at org.jboss.tools.openshift.internal.common.core.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:37)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)