[jbosstools-issues] [JBoss JIRA] (JBIDE-23473) Error decorator is not cleaned in New Openshift Application wizard -> Select template page -> Local template tab

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13319436#comment-13319436 ] 

Andre Dietisheim edited comment on JBIDE-23473 at 11/9/16 6:30 AM:
-------------------------------------------------------------------

[~aurelien.pupier] I cannot replicate this. Whether I type or paste, the URL is validated and the decorator disappears for me, once the url is valid. 

I see usability issues though: 
* Typing a url is unusable: validation occurrs on each keystroke. It disables the whole dialog and displays a progress for ~1 second. Typing becomes: type a key, wait, type another key, wait, etc. You cant type continously. We should correct this via ex. delayed validating: Validating only happens once there are no keystrokes for a few seconds.
* Decoration is not displayed inexistant file-urls (404): Formally invalid urls cause a decorator to appear to the left of the text field. Once the url is formally valid, the error marker on the field disappears (https://raw.githubusercontent.c -> https://raw.githubusercontent.co) even if the url is still not valid ex. because it's 404. I believe that there's a switch in failing validator. The url validator is displaying the decorator while the validator that tries to load the file isnt
See here: [^local-template-validation-weirdness.ogv]

[~aurelien.pupier] can you point me to what I miss? (see my screencast - local-template-validation-weirdness.ogv)


was (Author: adietish):
[~aurelien.pupier] I cannot replicate this. Whether I type or paste, the URL is validated and the decorator disappears for me, once the url is valid. 

I see a usability issue though: Typing is very annoying though, since the url is validated on each keystroke. Validating (which is most likely trying to load the file) disables the whole dialog, displays a progress for a second or so. Typing is not really an option like this. I think that we should correct this. Ex. with delayed validating: Validating only happens once there are no keystrokes for a few seconds.
And then there's another issue with the decoration: once the url is valid, the error marker on the field disappears (https://raw.githubusercontent.c -> https://raw.githubusercontent.co) and a different error is displayed in the title area. I believe that the failing validator is changing. The url validator is displaying the decorator while the validator that tries to load the file isnt, i believe:
[^local-template-validation-weirdness.ogv]

[~aurelien.pupier] can you point me to what I miss? (see my screencast - local-template-validation-weirdness.ogv)

> Error decorator is not cleaned in New Openshift Application wizard -> Select template page -> Local template tab
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23473
>                 URL: https://issues.jboss.org/browse/JBIDE-23473
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.2.AM2
>            Reporter: Aurélien Pupier
>            Assignee: Jeff MAURY
>            Priority: Minor
>         Attachments: image-2016-11-08-16-18-00-572.png, image-2016-11-08-16-18-00-572.png, local-template-validation-weirdness.ogv
>
>
>  !image-2016-11-08-16-18-00-572.png|thumbnail!



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)