[jbosstools-issues] [JBoss JIRA] (JBIDE-23486) Build: DeployImageJobtest#testStubImageStreamWhereOneDoesNotExistAndImageIsPublic is failing

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13321216#comment-13321216 ] 

Andre Dietisheim edited comment on JBIDE-23486 at 11/11/16 10:37 AM:
---------------------------------------------------------------------

[~jeffmaury] Can you please fix this test since you're the author of the patch. I am very unsure on how to fix this. My educated guess is that the assertion is wrong, but I'm not sure at all (spent quite some time without getting to a conclusive result). But then it also looks to me as "latest" being returned by is#getDockerImageRepository() is fishy.


was (Author: adietish):
[~jeffmaury] Can you please fix this test since you're the author of the patch. I am very unsure on how to fix this. My guess is that the assertion is wrong, but I'm not sure at all (spent quite some time without getting to a conclusive result).

> Build: DeployImageJobtest#testStubImageStreamWhereOneDoesNotExistAndImageIsPublic is failing
> --------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-23486
>                 URL: https://issues.jboss.org/browse/JBIDE-23486
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.2.AM3
>            Reporter: Andre Dietisheim
>            Assignee: Jeff MAURY
>            Priority: Critical
>             Fix For: 4.4.2.Final
>
>
> Our tests are failing
> {code}
> testStubImageStreamWhereOneDoesNotExistAndImageIsPublic(org.jboss.tools.openshift.test.ui.job.DeployImageJobTest)  Time elapsed: 0.016 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<repo/mynamespace/myimagename:latest> but was:<:latest>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:834)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:144)
> 	at org.jboss.tools.openshift.test.ui.job.DeployImageJobTest.testStubImageStreamWhereOneDoesNotExistAndImageIsPublic(DeployImageJobTest.java:219)
> {code}
> the failing assertion is the following:
> {code}
> assertEquals(new DockerImageURI("repo/mynamespace/myimagename:latest"), is.getDockerImageRepository());
> {code}
> Starting with [#1677|http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-openshift_master/1677/] our jenkins is thus failing.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)